Move shared tests to shared#837
Conversation
|
I think @matthargett mentioned there would either be NMock support for UWP or a decision to remove it throughout by EOW (which is EOD today). Can we wait on migrating further tests until that is resolved? |
|
None of these tests use NMock, but I don't want to sign off on removing yet more test coverage from UWP In reply to: 257005127 [](ancestors = 257005127) |
|
Yup! Sorry, this existed, and wanted to put it in a stable place for a hand-off if it goes forward. |
|
@rozele - Sounds like there is a plan from @matthargett - so this PR is just for reference as they implement separate testing. |
|
yes. @pre10der89 submitted PR #840 , which moves the few NMock-based tests to the ReactNative.Net46.Tests project, and adds ReactNative.Tests.Shared reference to the ReactNative.Tests Universal project. Once #840 is merged, this PR can be merged at no cost to coverage of the ReactNative Universal project. |
|
I ran into trouble migrating |
|
So, I guess I can't git... In the previous commit I moved the tests from UWP to shared and then tweaked them to be shared, but I guess that because the end result was closer to the Net46 tests (which I deleted) GitHub has decided to be "helpful" and change it so that I "moved" the Net46 tests and "deleted" the UWP tests... WAT. THE. WAT. |
| using System.Net; | ||
| using System.Net.Http; | ||
| using HttpStreamContent = System.Net.Http.StreamContent; | ||
| #endif |
There was a problem hiding this comment.
I don't think this is needed, we were only using it when HttpStreamContent was an output of a method. Here, you're just making constructor calls isolated in #ifs anyway, so its better not to type alias.
rozele
left a comment
rozele
left a comment
There was a problem hiding this comment.
Just the one comment about the type alias in NetworkingModuleTests then good to go.
|
@kevinvangelder can we close this if its superceded by #889 and #899? |
* Re-recreate #837 but moving from UWP w/o submodule changes * disabled appveyor cache settings to see if it fixes our test discovery issue * testing appveyor * hopefully fixed AppVeyor build * maybe separating the commands will help? * separate commands for real * hopefully working appveyor build * added missing $ * fixing error in appveyor.yml? * fixed appveyor for real this time
4 participants
Shared tests migrated to shared, to help test Net 4.6