Skip to content

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Potential Fitting for Hindered Rotors in Cantherm #1007

Closed
mjohnson541 opened this issue Apr 26, 2017 · 1 comment
Closed

Potential Fitting for Hindered Rotors in Cantherm #1007

mjohnson541 opened this issue Apr 26, 2017 · 1 comment
Labels
Arkane stale stale issue/PR as determined by actions bot

Comments

@mjohnson541
Copy link
Contributor

mjohnson541 commented Apr 26, 2017

Currently hindered rotor potentials are fit to a Fourier series and a cosine/symmetry fit and the best is used. This has resulted in numerous problems related to using too few or too many Fourier coefficients and the cosine/symmetry fit being too simple to capture the potential.

Why don't we just use a simple set of cubic splines instead? The problem with a Fourier series is that it is a sum of oscillatory modes so adding an extra Fourier series term means adding an extra oscillatory mode to your potential, which can distort the potential shape. Cubic splines are local and thus won't have that problem. The only real issue with this is if quantum happens to be on, in which case we could switch back to the Fourier basis or use a different solution method.

#1006

@github-actions
Copy link

This issue is being automatically marked as stale because it has not received any interaction in the last 90 days. Please leave a comment if this is still a relevant issue, otherwise it will automatically be closed in 30 days.

@github-actions github-actions bot added the stale stale issue/PR as determined by actions bot label Jun 22, 2023
@ReactionMechanismGenerator ReactionMechanismGenerator locked and limited conversation to collaborators Jun 22, 2023
@mjohnson541 mjohnson541 converted this issue into discussion #2477 Jun 22, 2023

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

Labels
Arkane stale stale issue/PR as determined by actions bot
Projects
None yet
Development

No branches or pull requests

1 participant