Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Currently not working when DASPK is not available #2070

Closed
mark-pfeifle opened this issue Feb 11, 2021 · 4 comments · Fixed by #2615
Closed

Currently not working when DASPK is not available #2070

mark-pfeifle opened this issue Feb 11, 2021 · 4 comments · Fixed by #2615
Labels
bug bug which will never be closed by the actions bot Good First Issue
Projects
April 2021 Hackathon

Comments

@mark-pfeifle
Copy link

There is currently a bug in rmgpy/solver/base.pyx:

" from pydas.daspk import DASSLError as DASxError"

in one of the first code lines. This should read

" from pydas.dassl import DASSLError as DASxError"

Otherwise, if daspk is not available, the program will still try to access pydas.daspk.
This applies to the latest commit on master as of Feb 11 2021.

Best regards,
Mark
@amarkpayne amarkpayne added this to To consider in April 2021 Hackathon via automation Apr 14, 2021
@github-actions
Copy link

This issue is being automatically marked as stale because it has not received any interaction in the last 90 days. Please leave a comment if this is still a relevant issue, otherwise it will automatically be closed in 30 days.

@github-actions github-actions bot added the stale stale issue/PR as determined by actions bot label Jun 21, 2023
@mark-pfeifle
Copy link
Author

I've been automatically notified that this is a stale issue now. As far as I can see, the bug is still present in the code.

@github-actions github-actions bot removed the stale stale issue/PR as determined by actions bot label Jun 22, 2023
@JacksonBurns
Copy link
Contributor

Hi @mark-pfeifle thanks for the followup! I am going to add the bug label to this so that it won't be bothered by the bot, and we will try and get toward resolving this.

@JacksonBurns JacksonBurns added the bug bug which will never be closed by the actions bot label Jun 22, 2023
Julian-Ufert added a commit to Julian-Ufert/RMG-Py that referenced this issue Feb 27, 2024
@Julian-Ufert
changed typo from pydas.daspk to pydas.dassl ReactionMechanismGenerat…
6425eea 
…or#2070
@Julian-Ufert
Copy link
Contributor

I changed the respective code line. Please pull the changes into the upstream.

@Julian-Ufert Julian-Ufert mentioned this issue Feb 27, 2024
Merged
@JacksonBurns JacksonBurns linked a pull request Feb 27, 2024 that will close this issue
changed typo from pydas.daspk to pydas.dassl #2070 #2615
Merged
JacksonBurns added a commit that referenced this issue Feb 28, 2024
@JacksonBurns
Merge pull request #2615 from Julian-Ufert/main
0419c44 
changed typo from pydas.daspk to pydas.dassl #2070
ntietje1 pushed a commit to ntietje1/RMG-Py that referenced this issue Mar 11, 2024
@Julian-Ufert @ntietje1
changed typo from pydas.daspk to pydas.dassl ReactionMechanismGenerat…
892760a 
…or#2070
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug bug which will never be closed by the actions bot Good First Issue
Projects
April 2021 Hackathon
To consider
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

changed typo from pydas.daspk to pydas.dassl #2070 Julian-Ufert/RMG-Py
4 participants
@amarkpayne @JacksonBurns @mark-pfeifle @Julian-Ufert