Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pressure unit mbar doesn't function in RMG, and a general units question #855

Closed
alongd opened this issue Dec 27, 2016 · 1 comment
Closed
Labels
abandoned abandoned issue/PR as determined by actions bot stale stale issue/PR as determined by actions bot Type: Documentation

Comments

@alongd
Copy link
Member

alongd commented Dec 27, 2016

The mbar pressure unit appears in commonUnits in quantity.py, but it doesn't get converted into Pa in main.py.
This unit is not mandatory, since RMG's existing pressure units already cover the realistic pressure range without using too many zeros. However, including it will avoid an unnecessary job crash (I got: LookupError: Unable to parse units: "mbar").

Perhaps more important, I couldn't find in the documentation (i.e., without looking at the code) which units are allowed for frequently used dimensions in RMG. I guess including this in the documentation could be helpful for users? (or have I missed it?)

@github-actions
Copy link

This issue is being automatically marked as stale because it has not received any interaction in the last 90 days. Please leave a comment if this is still a relevant issue, otherwise it will automatically be closed in 30 days.

@github-actions github-actions bot added the stale stale issue/PR as determined by actions bot label Jun 22, 2023
@github-actions github-actions bot added the abandoned abandoned issue/PR as determined by actions bot label Jul 23, 2023
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Jul 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
abandoned abandoned issue/PR as determined by actions bot stale stale issue/PR as determined by actions bot Type: Documentation
Projects
None yet
Development

No branches or pull requests

2 participants