Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BugFix: file_format in ReactionDrawer #1760

Closed
wants to merge 1 commit into from
Closed

Conversation

alongd
Copy link
Member

@alongd alongd commented Oct 11, 2019

These are leftovers from the PEP8 conversions where the reserved keyword format was replaced with file_format in draw.py.
This fixed was verified to function correctly (within ARC).

These are leftovers from the PEP8 conversions where the reserved word `format` was replaced with `file_format` in draw.py
@alongd alongd requested a review from mliu49 October 11, 2019 01:51
@codecov
Copy link

codecov bot commented Oct 11, 2019

Codecov Report

Merging #1760 into master will not change coverage.
The diff coverage is 0%.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #1760   +/-   ##
======================================
  Coverage    32.6%   32.6%           
======================================
  Files          87      87           
  Lines       26115   26115           
  Branches     6875    6875           
======================================
  Hits         8516    8516           
+ Misses      16641   16629   -12     
- Partials      958     970   +12
Impacted Files Coverage Δ
rmgpy/molecule/draw.py 40.17% <0%> (ø) ⬆️
rmgpy/data/statmech.py 42.2% <0%> (ø) ⬆️
rmgpy/rmg/pdep.py 12.21% <0%> (ø) ⬆️
rmgpy/reaction.py 0% <0%> (ø) ⬆️
rmgpy/data/kinetics/family.py 48.28% <0%> (ø) ⬆️
rmgpy/yml.py 15.71% <0%> (ø) ⬆️
rmgpy/data/kinetics/database.py 50.61% <0%> (ø) ⬆️
rmgpy/molecule/molecule.py 0% <0%> (ø) ⬆️
rmgpy/statmech/ndTorsions.py 59.78% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1f95dba...cb92457. Read the comment docs.

@mliu49
Copy link
Contributor

mliu49 commented Oct 11, 2019

This fix is already part of #1735.

@alongd
Copy link
Member Author

alongd commented Oct 11, 2019

Great! I'll go ahead and close this PR.

@alongd alongd closed this Oct 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants