-
Notifications
You must be signed in to change notification settings - Fork 226
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve Rule Generation #2277
Closed
Closed
Improve Rule Generation #2277
Changes from 1 commit
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
e6110e9
add solute data to KineticsModel and Arrhenius
mjohnson541 a51925e
add ArrheniusChargeTransfer kinetics type
mjohnson541 aa39337
create ArrheniusChargeTransferBM type
mjohnson541 95db806
add ChargeTransfer types to kinetics/__init__.py
mjohnson541 25807c1
handle ChargeTransfer kinetics with in reaction.py
mjohnson541 908bad9
add handling ArrheniusChargeTransfer and fix handling SurfaceChargeTr…
mjohnson541 68d43d5
enable access to SoluteData object in kinetics database
mjohnson541 8d30987
when rule making is done on one processor don't use pool
mjohnson541 d81d824
add function for averaging kinetics
mjohnson541 1898402
update rule fitting
mjohnson541 5c727f1
enable use of non-surface charge transfer families
mjohnson541 321dbb8
add charge transfer types to database context
mjohnson541 1601dc8
standardize ascend option in cross validate
mjohnson541 58a9ef0
add comment to averaged kinetics
mjohnson541 ea72bf4
fix BM fitting
mjohnson541 4174c91
added Faraday's Constant `F`
davidfarinajr File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you explain why removing this? (in the commit message, ideally)