Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add bib file #2357

Merged
Merged

Conversation

JacksonBurns
Copy link
Contributor

Re-doing #2346

Copy link
Contributor

@xiaoruiDong xiaoruiDong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@JacksonBurns
Copy link
Contributor Author

The failed documentation build seems to be a known issue with Julia (?) - the PyJulia documentation also provides troubleshooting options which I found helpful during the RMG install.

@codecov
Copy link

codecov bot commented Jan 18, 2023

Codecov Report

Merging #2357 (123d4f5) into main (04c61f8) will decrease coverage by 0.67%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #2357      +/-   ##
==========================================
- Coverage   48.25%   47.58%   -0.67%     
==========================================
  Files         110      110              
  Lines       30605    30605              
  Branches     7981     7981              
==========================================
- Hits        14769    14564     -205     
- Misses      14292    14525     +233     
+ Partials     1544     1516      -28     
Impacted Files Coverage Δ
rmgpy/qm/molecule.py 37.55% <0.00%> (-43.27%) ⬇️
rmgpy/qm/mopac.py 26.43% <0.00%> (-41.38%) ⬇️
rmgpy/qm/qmdata.py 52.77% <0.00%> (-27.78%) ⬇️
rmgpy/qm/main.py 51.61% <0.00%> (-13.71%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@xiaoruiDong
Copy link
Contributor

Ran into an error in building documentation. Not relevant to the change in this PR but will potentially influence the online documentation. @alongd I remember you mentioned the same issue several days ago. Have you solved it?

@xiaoruiDong
Copy link
Contributor

The failed documentation build seems to be a known issue with Julia (?) - the PyJulia documentation also provides troubleshooting options which I found helpful during the RMG install.

Sorry, I missed your reply. Do you know if someone is implementing or plans to implement this into the CI procedure?

@JacksonBurns
Copy link
Contributor Author

The failed documentation build seems to be a known issue with Julia (?) - the PyJulia documentation also provides troubleshooting options which I found helpful during the RMG install.

Sorry, I missed your reply. Do you know if someone is implementing or plans to implement this into the CI procedure?

I do not, and I'm not sure that this is the actual problem. It could be more like the LD_LIBRARY_PATH as in #2353

@xiaoruiDong xiaoruiDong merged commit f366048 into ReactionMechanismGenerator:main Feb 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants