-
Notifications
You must be signed in to change notification settings - Fork 227
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make the Continuous Integration Pass by Default #2500
Conversation
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
6b41bf5
to
f87a2ff
Compare
- only test solving environment and building RMG on Mac, no testing (we distribute on ubuntu anyway) - remove requirement for regression comparisons to pass - comment the results to the PR - beep boop 🤖
f87a2ff
to
e4e9eb4
Compare
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This looks good, really like the bot. I might have missed it but do we know why the MacOS runners can't build the julia dependencies? |
Thanks! See #2453 TL;DR: the GitHub runners just don't seem up to the task. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me! Thanks putting the PR together.
This was a minor bug.
Made tables, reactions, species, into markdown, and added some emoji. These reports now get pasted into the github pull request comments by a bot, so trying to make them look nice once formatted by github-flavored-markdown.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. I added some commits to tweak the formatting. Let's see if they work as intended...
The In this run https://github.com/ReactionMechanismGenerator/RMG-Py/actions/runs/5590577981/jobs/10220474560 the mac runner carried on to the julia step, timed out, and failed (thus killing the ubuntu run). And in this run https://github.com/ReactionMechanismGenerator/RMG-Py/actions/runs/5590578639/jobs/10220475578 the mac runner is still going. |
Ah, I had done this differently on a previous commit like this and then changed it to this hoping it would work. Fixing now. |
Regression Testing Results==> test/regression-diff/RMS_CSTR_liquid_oxidation-edge.log <== Non-identical kinetics! ❌
kinetics: ==> test/regression-diff/aromatics-edge.log <== Non-identical thermo! ❌
thermo: Thermo group additivity estimation: group(Cs-(Cds-Cds)(Cds-Cds)(Cds-Cds)H) + group(Cds-Cds(Cds-Cds)(Cds-Cds)) + group(Cds-CdsCsH) + group(Cds-CdsCsH) + group(Cds-Cds(Cds-Cds)H) + group(Cds-Cds(Cds-Cds)H) + group(Cds-CdsCsH) + group(Cdd-CdsCds) + Estimated bicyclic component: polycyclic(s4_6_6_ane) - ring(Cyclohexane) - ring(Cyclohexane) + ring(124cyclohexatriene) + ring(1,4-Cyclohexadiene) Non-identical kinetics! ❌
kinetics: Non-identical kinetics! ❌
kinetics: Non-identical kinetics! ❌
kinetics: Non-identical kinetics! ❌
kinetics: Non-identical kinetics! ❌
kinetics: Non-identical kinetics! ❌
kinetics: Non-identical kinetics! ❌
kinetics: Non-identical kinetics! ❌
kinetics: Non-identical kinetics! ❌
kinetics: Non-identical kinetics! ❌
kinetics: Non-identical kinetics! ❌
kinetics: Non-identical kinetics! ❌
kinetics: Non-identical kinetics! ❌
kinetics: ==> test/regression-diff/liquid_oxidation-edge.log <== Non-identical kinetics! ❌
kinetics: ==> test/regression-diff/nitrogen-edge.log <== Non-identical thermo! ❌
Non-identical kinetics! ❌
kinetics: ==> test/regression-diff/sulfur-edge.log <== beep boop this action was performed by a bot 🤖 |
I like it! Looks good to me! |
I merged this, so that we can get all the other pull requests to use it, but I can think of a couple of further improvemenst.
|
Regression Testing Results==> test/regression-diff/RMS_CSTR_liquid_oxidation-edge.log <== Non-identical kinetics! ❌
kinetics: ==> test/regression-diff/liquid_oxidation-core.log <== Non-identical kinetics! ❌
kinetics: ==> test/regression-diff/liquid_oxidation-edge.log <== Non-identical kinetics! ❌
kinetics: ==> test/regression-diff/sulfur-edge.log <== beep boop this action was performed by a bot 🤖 |
Right now the regression tests are failing by default - this PR implements the following to fix that: