Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reconciling Electrochem Branch with main #2598

Draft
wants to merge 149 commits into
base: main
Choose a base branch
from
Draft

Reconciling Electrochem Branch with main #2598

wants to merge 149 commits into from
+6,171 −672

Commits on Jun 14, 2024

  1. Add reaction library to test example for liquidSurfaceReactor

    @mjohnson541 @rwest
    mjohnson541 authored and rwest committed Jun 14, 2024
    Configuration menu
    Copy the full SHA
    5c952a0 View commit details
    Browse the repository at this point in the history

  2. added Faraday's Constant F

    @davidfarinajr @rwest
    davidfarinajr authored and rwest committed Jun 14, 2024
    Configuration menu
    Copy the full SHA
    f161c1a View commit details
    Browse the repository at this point in the history

  3. added Potential as V quantity

    @davidfarinajr @rwest
    davidfarinajr authored and rwest committed Jun 14, 2024
    Configuration menu
    Copy the full SHA
    8df2232 View commit details
    Browse the repository at this point in the history

  4. added H+ and e atomtypes, increment/decrement charge attributes

    @davidfarinajr @rwest
    davidfarinajr authored and rwest committed Jun 14, 2024
    Configuration menu
    Copy the full SHA
    f374d89 View commit details
    Browse the repository at this point in the history

  5. Added increment_charge and decrement_charge to Rx 

    and Rx!H atom types
    @ssun30 @rwest
    ssun30 authored and rwest committed Jun 14, 2024
    Configuration menu
    Copy the full SHA
    1fa737b View commit details
    Browse the repository at this point in the history

  6. H -> H0 in find_h_bonds Molecule method

    @davidfarinajr @rwest
    davidfarinajr authored and rwest committed Jun 14, 2024
    Configuration menu
    Copy the full SHA
    77c1321 View commit details
    Browse the repository at this point in the history

  7. added gain_charge and lose_charge actions

    @davidfarinajr @rwest
    davidfarinajr authored and rwest committed Jun 14, 2024
    Configuration menu
    Copy the full SHA
    6260669 View commit details
    Browse the repository at this point in the history

  8. added is_proton and is_electron group methods

    @davidfarinajr @rwest
    davidfarinajr authored and rwest committed Jun 14, 2024
    Configuration menu
    Copy the full SHA
    606d870 View commit details
    Browse the repository at this point in the history

  9. added group unit tests

    @davidfarinajr @rwest
    davidfarinajr authored and rwest committed Jun 14, 2024
    Configuration menu
    Copy the full SHA
    7691ac9 View commit details
    Browse the repository at this point in the history

  10. added is_electron and is_proton methods to Atom and Mol

    @davidfarinajr @rwest
    davidfarinajr authored and rwest committed Jun 14, 2024
    Configuration menu
    Copy the full SHA
    676172a View commit details
    Browse the repository at this point in the history

  11. added GAIN and LOSE CHARGE actions to Atoms

    @davidfarinajr @rwest
    davidfarinajr authored and rwest committed Jun 14, 2024
    Configuration menu
    Copy the full SHA
    561b8af View commit details
    Browse the repository at this point in the history

  12. added updated charge method and revised update Molecule method 

    the update method now updates lone pairs before updating charge
    @davidfarinajr @rwest
    davidfarinajr authored and rwest committed Jun 14, 2024
    Configuration menu
    Copy the full SHA
    15c5dd5 View commit details
    Browse the repository at this point in the history

  13. do not raise charge exception by default when creating molecule from … 

    …adj list
    @davidfarinajr @rwest
    davidfarinajr authored and rwest committed Jun 14, 2024
    Configuration menu
    Copy the full SHA
    689ac52 View commit details
    Browse the repository at this point in the history

  14. try to generate_resonance_structures, and return a deep copy of the m… 

    …olecule if it fails
    @davidfarinajr @rwest
    davidfarinajr authored and rwest committed Jun 14, 2024
    Configuration menu
    Copy the full SHA
    eb36a15 View commit details
    Browse the repository at this point in the history

  15. added molecule.pxd declarations

    @davidfarinajr @rwest
    davidfarinajr authored and rwest committed Jun 14, 2024
    Configuration menu
    Copy the full SHA
    8d14efb View commit details
    Browse the repository at this point in the history

  16. added Species is_electron and is_proton methods

    @davidfarinajr @rwest
    davidfarinajr authored and rwest committed Jun 14, 2024
    Configuration menu
    Copy the full SHA
    fc4f513 View commit details
    Browse the repository at this point in the history

  17. do not raise charge exception by default when creating species from a… 

    …dj list
    @davidfarinajr @rwest
    davidfarinajr authored and rwest committed Jun 14, 2024
    Configuration menu
    Copy the full SHA
    54ba0b1 View commit details
    Browse the repository at this point in the history

  18. added get_net_charge method for Species

    @davidfarinajr @rwest
    davidfarinajr authored and rwest committed Jun 14, 2024
    Configuration menu
    Copy the full SHA
    de669c5 View commit details
    Browse the repository at this point in the history

  19. do not forbid ions 

    however, we still need better thermo
    @davidfarinajr @rwest
    davidfarinajr authored and rwest committed Jun 14, 2024
    Configuration menu
    Copy the full SHA
    4246478 View commit details
    Browse the repository at this point in the history

  20. added SurfaceChargeTransfer and SurfaceChargeTransferBEP kinetic … 

    …models
    @davidfarinajr @rwest
    davidfarinajr authored and rwest committed Jun 14, 2024
    Configuration menu
    Copy the full SHA
    bcedaa5 View commit details
    Browse the repository at this point in the history

  21. added Molecule unit tests

    @davidfarinajr @rwest
    davidfarinajr authored and rwest committed Jun 14, 2024
    Configuration menu
    Copy the full SHA
    524faad View commit details
    Browse the repository at this point in the history

  22. added electrons reaction attr and reaction methods for charge trans… 

    …fer reactions
    @davidfarinajr @rwest
    davidfarinajr authored and rwest committed Jun 14, 2024
    Configuration menu
    Copy the full SHA
    6f92855 View commit details
    Browse the repository at this point in the history

  23. added reaction tests for charge transfer reactions 

    port the new reaction tests to the new testing file and style
by Jackson Burns <jwburns@mit.edu>
Date:	Thu Feb 01 2024 10:47:18 GMT-0500 (Eastern Standard Time)

Co-authored-by: davidfarinajr <farina.d@northeastern.edu>
Co-authored-by: Jackson Burns <jwburns@mit.edu>
    @davidfarinajr @JacksonBurns @rwest
    2 people authored and rwest committed Jun 14, 2024
    Configuration menu
    Copy the full SHA
    cd9960e View commit details
    Browse the repository at this point in the history

  24. adding charged species and electrons to family.py

    @davidfarinajr @rwest
    davidfarinajr authored and rwest committed Jun 14, 2024
    Configuration menu
    Copy the full SHA
    4f0f6a3 View commit details
    Browse the repository at this point in the history

  25. added family test for Surface_Proton_Electron_Reduction_Alpha family

    @davidfarinajr @rwest
    davidfarinajr authored and rwest committed Jun 14, 2024
    Configuration menu
    Copy the full SHA
    1e192e7 View commit details
    Browse the repository at this point in the history

  26. added support for loading SurfaceChargeTransfer kinetics from the d… 

    …atabase
    @davidfarinajr @rwest
    davidfarinajr authored and rwest committed Jun 14, 2024
    Configuration menu
    Copy the full SHA
    cb26bc1 View commit details
    Browse the repository at this point in the history

  27. update charge before updating lone pairs for solvation `transform_lon… 

    …e_pairs` method
    @davidfarinajr @rwest
    davidfarinajr authored and rwest committed Jun 14, 2024
    Configuration menu
    Copy the full SHA
    0d0d8f9 View commit details
    Browse the repository at this point in the history

  28. making rules for SurfaceChargeTransfer training reactions

    @davidfarinajr @rwest
    davidfarinajr authored and rwest committed Jun 14, 2024
    Configuration menu
    Copy the full SHA
    16920bf View commit details
    Browse the repository at this point in the history

  29. added SurfaceChargeTransfer kinetics import

    @davidfarinajr @rwest
    davidfarinajr authored and rwest committed Jun 14, 2024
    Configuration menu
    Copy the full SHA
    aed1e28 View commit details
    Browse the repository at this point in the history

  30. added H+ and e to translator

    @davidfarinajr @rwest
    davidfarinajr authored and rwest committed Jun 14, 2024
    Configuration menu
    Copy the full SHA
    4b49a43 View commit details
    Browse the repository at this point in the history

  31. update_atomtypes -> update in translator.py

    @davidfarinajr @rwest
    davidfarinajr authored and rwest committed Jun 14, 2024
    Configuration menu
    Copy the full SHA
    6226f17 View commit details
    Browse the repository at this point in the history

  32. added SurfaceChargeTransfer to yml

    @davidfarinajr @rwest
    davidfarinajr authored and rwest committed Jun 14, 2024
    Configuration menu
    Copy the full SHA
    95167d1 View commit details
    Browse the repository at this point in the history

  33. added adsorption_groups attr to thermoDB

    @davidfarinajr @rwest
    davidfarinajr authored and rwest committed Jun 14, 2024
    Configuration menu
    Copy the full SHA
    f9097dd View commit details
    Browse the repository at this point in the history

  34. added fluorine to thermo correct_binding_energy method

    @davidfarinajr @rwest
    davidfarinajr authored and rwest committed Jun 14, 2024
    Configuration menu
    Copy the full SHA
    a3580c2 View commit details
    Browse the repository at this point in the history

  35. add LiH and LiF to atom energy corrections fitting species list

    @mjohnson541 @rwest
    mjohnson541 authored and rwest committed Jun 14, 2024
    Configuration menu
    Copy the full SHA
    0a64bbc View commit details
    Browse the repository at this point in the history

  36. add Li atom spin

    @mjohnson541 @rwest
    mjohnson541 authored and rwest committed Jun 14, 2024
    Configuration menu
    Copy the full SHA
    60969b5 View commit details
    Browse the repository at this point in the history

  37. don't check Li partial charges in adjlists

    @mjohnson541 @rwest
    mjohnson541 authored and rwest committed Jun 14, 2024
    Configuration menu
    Copy the full SHA
    43e98a4 View commit details
    Browse the repository at this point in the history

  38. add Li atomtype

    @mjohnson541 @rwest
    mjohnson541 authored and rwest committed Jun 14, 2024
    Configuration menu
    Copy the full SHA
    7c93597 View commit details
    Browse the repository at this point in the history

  39. add atom information for Li

    @mjohnson541 @rwest
    mjohnson541 authored and rwest committed Jun 14, 2024
    Configuration menu
    Copy the full SHA
    fe78686 View commit details
    Browse the repository at this point in the history

  40. add Li to R and R!H lists

    @mjohnson541 @rwest
    mjohnson541 authored and rwest committed Jun 14, 2024
    Configuration menu
    Copy the full SHA
    375525f View commit details
    Browse the repository at this point in the history

  41. add Li0 and Li+ atomtypes

    @mjohnson541 @rwest
    mjohnson541 authored and rwest committed Jun 14, 2024
    Configuration menu
    Copy the full SHA
    d803a53 View commit details
    Browse the repository at this point in the history

  42. add Li McGowan volume

    @mjohnson541 @rwest
    mjohnson541 authored and rwest committed Jun 14, 2024
    Configuration menu
    Copy the full SHA
    ba7c51e View commit details
    Browse the repository at this point in the history

  43. add additional Li BDEs

    @mjohnson541 @rwest
    mjohnson541 authored and rwest committed Jun 14, 2024
    Configuration menu
    Copy the full SHA
    f9f12ba View commit details
    Browse the repository at this point in the history

  44. add Li to bond dictionaries in thermo

    @mjohnson541 @rwest
    mjohnson541 authored and rwest committed Jun 14, 2024
    Configuration menu
    Copy the full SHA
    4c80959 View commit details
    Browse the repository at this point in the history

  45. handle Lithium electron calculations

    @mjohnson541 @rwest
    mjohnson541 authored and rwest committed Jun 14, 2024
    Configuration menu
    Copy the full SHA
    309b5b0 View commit details
    Browse the repository at this point in the history

  46. add is_lithium for GroupAtom

    @mjohnson541 @rwest
    mjohnson541 authored and rwest committed Jun 14, 2024
    Configuration menu
    Copy the full SHA
    8c3d819 View commit details
    Browse the repository at this point in the history

  47. handle SurfaceChargeTransfer in to_rms

    @mjohnson541 @rwest
    mjohnson541 authored and rwest committed Jun 14, 2024
    Configuration menu
    Copy the full SHA
    a3f1f76 View commit details
    Browse the repository at this point in the history

  48. filter out resonance structures that try to put - charges on Li 

    fix resonance bug (squash)
    @mjohnson541 @rwest
    mjohnson541 authored and rwest committed Jun 14, 2024
    Configuration menu
    Copy the full SHA
    549ca38 View commit details
    Browse the repository at this point in the history

  49. ensure atomtypes get updated on loading in thermo entries

    @mjohnson541 @rwest
    mjohnson541 authored and rwest committed Jun 14, 2024
    Configuration menu
    Copy the full SHA
    1f3368f View commit details
    Browse the repository at this point in the history

  50. add solute data to KineticsModel and Arrhenius

    @mjohnson541 @rwest
    mjohnson541 authored and rwest committed Jun 14, 2024
    Configuration menu
    Copy the full SHA
    5f59db2 View commit details
    Browse the repository at this point in the history

  51. add ArrheniusChargeTransfer kinetics type

    @mjohnson541 @rwest
    mjohnson541 authored and rwest committed Jun 14, 2024
    Configuration menu
    Copy the full SHA
    0b3ccff View commit details
    Browse the repository at this point in the history

  52. create ArrheniusChargeTransferBM type

    @mjohnson541 @rwest
    mjohnson541 authored and rwest committed Jun 14, 2024
    Configuration menu
    Copy the full SHA
    acebc62 View commit details
    Browse the repository at this point in the history

  53. add ChargeTransfer types to kinetics/__init__.py

    @mjohnson541 @rwest
    mjohnson541 authored and rwest committed Jun 14, 2024
    Configuration menu
    Copy the full SHA
    8e74f64 View commit details
    Browse the repository at this point in the history

  54. avoid issue with auto decay reactions

    @mjohnson541 @rwest
    mjohnson541 authored and rwest committed Jun 14, 2024
    Configuration menu
    Copy the full SHA
    ac0cf25 View commit details
    Browse the repository at this point in the history

  55. handle ChargeTransfer kinetics with in reaction.py

    @mjohnson541 @rwest
    mjohnson541 authored and rwest committed Jun 14, 2024
    Configuration menu
    Copy the full SHA
    6b33400 View commit details
    Browse the repository at this point in the history

  56. add handling ArrheniusChargeTransfer and fix handling SurfaceChargeTr… 

    …ansfer for rms output
    @mjohnson541 @rwest
    mjohnson541 authored and rwest committed Jun 14, 2024
    Configuration menu
    Copy the full SHA
    6cd956d View commit details
    Browse the repository at this point in the history

  57. Revert "Remove charge transfer types from average_kinetics (to be rev… 

    …erted)"

This reverts commit 2180175.

I also tweaked it a little bit.
    @rwest
    rwest committed Jun 14, 2024
    Configuration menu
    Copy the full SHA
    d2762fd View commit details
    Browse the repository at this point in the history

  58. enable access to SoluteData object in kinetics database

    @mjohnson541 @rwest
    mjohnson541 authored and rwest committed Jun 14, 2024
    Configuration menu
    Copy the full SHA
    fcc261c View commit details
    Browse the repository at this point in the history

  59. update rule fitting 

    1) Enable fitting of ArrheniusChargeTransferBM
2) if the BM fit is bad: E0 < 0, A > 1e30 or abs(n) > 5 just average the kinetics
    @mjohnson541 @rwest
    mjohnson541 authored and rwest committed Jun 14, 2024
    Configuration menu
    Copy the full SHA
    2f6dbb7 View commit details
    Browse the repository at this point in the history

  60. enable use of non-surface charge transfer families

    @mjohnson541 @rwest
    mjohnson541 authored and rwest committed Jun 14, 2024
    Configuration menu
    Copy the full SHA
    4f1d14b View commit details
    Browse the repository at this point in the history

  61. add charge transfer types to database context

    @mjohnson541 @rwest
    mjohnson541 authored and rwest committed Jun 14, 2024
    Configuration menu
    Copy the full SHA
    27e0036 View commit details
    Browse the repository at this point in the history

  62. enable surface and bulk potentials to be specified separately

    @mjohnson541 @rwest
    mjohnson541 authored and rwest committed Jun 14, 2024
    Configuration menu
    Copy the full SHA
    23309ae View commit details
    Browse the repository at this point in the history

  63. Allow approximating a solvent not in the database with another solvent

    @mjohnson541 @rwest
    mjohnson541 authored and rwest committed Jun 14, 2024
    Configuration menu
    Copy the full SHA
    93f9930 View commit details
    Browse the repository at this point in the history

  64. standardize ascend option in cross validate 

    ascend based on original uncertainties and compute errors at that node in cross validate
    @mjohnson541 @rwest
    mjohnson541 authored and rwest committed Jun 14, 2024
    Configuration menu
    Copy the full SHA
    9757f8f View commit details
    Browse the repository at this point in the history

  65. Average kinetics when n=1 or E0<0

    @mjohnson541 @rwest
    mjohnson541 authored and rwest committed Jun 14, 2024
    Configuration menu
    Copy the full SHA
    833c82a View commit details
    Browse the repository at this point in the history

  66. add comment to averaged kinetics 

    (Commit updated by rwest during rebase:
In the original commit the  comment used to specify /why/ 
it was averaged, but it is added in the averaging method itself.
The /why/, if needed, should be added elsewhere.)
    @mjohnson541 @rwest
    mjohnson541 authored and rwest committed Jun 14, 2024
    Configuration menu
    Copy the full SHA
    abc2c9d View commit details
    Browse the repository at this point in the history

  67. fix BM fitting 

    consistenty use dH298
do not estimate e0 = w0/10 when  |dHrxn| > 0.4w0
    @mjohnson541 @rwest
    mjohnson541 authored and rwest committed Jun 14, 2024
    Configuration menu
    Copy the full SHA
    31ac267 View commit details
    Browse the repository at this point in the history

  68. add functions for solvent correcting kinetics

    @mjohnson541 @rwest
    mjohnson541 authored and rwest committed Jun 14, 2024
    Configuration menu
    Copy the full SHA
    b33b1f5 View commit details
    Browse the repository at this point in the history

  69. add functionality for site specific solvent corrections

    @mjohnson541 @rwest
    mjohnson541 authored and rwest committed Jun 14, 2024
    Configuration menu
    Copy the full SHA
    5ea3f64 View commit details
    Browse the repository at this point in the history

  70. apply_solvent_correction in fix_barrier_height

    @mjohnson541 @rwest
    mjohnson541 authored and rwest committed Jun 14, 2024
    Configuration menu
    Copy the full SHA
    4bb2f78 View commit details
    Browse the repository at this point in the history

  71. enable solvent parameters to be directly specified in input file

    @mjohnson541 @rwest
    mjohnson541 authored and rwest committed Jun 14, 2024
    Configuration menu
    Copy the full SHA
    cbe2d9f View commit details
    Browse the repository at this point in the history

  72. adapt fix_barrier_height calls

    @mjohnson541 @rwest
    mjohnson541 authored and rwest committed Jun 14, 2024
    Configuration menu
    Copy the full SHA
    8e9925d View commit details
    Browse the repository at this point in the history

  73. handle ArrheniusChargeTransfer => Arrheniusq

    @mjohnson541 @rwest
    mjohnson541 authored and rwest committed Jun 14, 2024
    Configuration menu
    Copy the full SHA
    34b4e1c View commit details
    Browse the repository at this point in the history

  74. add index of refraction to SolventData objects

    @mjohnson541 @rwest
    mjohnson541 authored and rwest committed Jun 14, 2024
    Configuration menu
    Copy the full SHA
    c16076b View commit details
    Browse the repository at this point in the history

  75. fix KineticsModel outputs

    @mjohnson541 @rwest
    mjohnson541 authored and rwest committed Jun 14, 2024
    Configuration menu
    Copy the full SHA
    2fe02d7 View commit details
    Browse the repository at this point in the history

  76. add SoluteTSData object

    @mjohnson541 @rwest
    mjohnson541 authored and rwest committed Jun 14, 2024
    Configuration menu
    Copy the full SHA
    0d8b859 View commit details
    Browse the repository at this point in the history

  77. add SoluteTSDIffData object

    @mjohnson541 @rwest
    mjohnson541 authored and rwest committed Jun 14, 2024
    Configuration menu
    Copy the full SHA
    ea76b7c View commit details
    Browse the repository at this point in the history

  78. add function to convert SoluteData and SoluteTSDiffData to SoluteTSData

    @mjohnson541 @rwest
    mjohnson541 authored and rwest committed Jun 14, 2024
    Configuration menu
    Copy the full SHA
    3456ba2 View commit details
    Browse the repository at this point in the history

  79. Enable database to understand new objects

    @mjohnson541 @rwest
    mjohnson541 authored and rwest committed Jun 14, 2024
    Configuration menu
    Copy the full SHA
    5115865 View commit details
    Browse the repository at this point in the history

  80. Enable LibraryReaction to handle SoluteTSData

    @mjohnson541 @rwest
    mjohnson541 authored and rwest committed Jun 14, 2024
    Configuration menu
    Copy the full SHA
    7ccb593 View commit details
    Browse the repository at this point in the history

  81. Enable TemplateReaction to handle new TS solvent corrections

    @mjohnson541 @rwest
    mjohnson541 authored and rwest committed Jun 14, 2024
    Configuration menu
    Copy the full SHA
    b63d559 View commit details
    Browse the repository at this point in the history

  82. only use kinetics that have arrhenius forms for tree generation 

    the TS solute data is used only for rule fitting after tree is generated

fix tab error
    @mjohnson541 @rwest
    mjohnson541 authored and rwest committed Jun 14, 2024
    Configuration menu
    Copy the full SHA
    a6480d5 View commit details
    Browse the repository at this point in the history

  83. enable solute data to be pulled from further up the tree as necessary

    @mjohnson541 @rwest
    mjohnson541 authored and rwest committed Jun 14, 2024
    Configuration menu
    Copy the full SHA
    bdafd8e View commit details
    Browse the repository at this point in the history

  84. enable fitting of TS solute rules

    @mjohnson541 @rwest
    mjohnson541 authored and rwest committed Jun 14, 2024
    Configuration menu
    Copy the full SHA
    b83be6e View commit details
    Browse the repository at this point in the history

  85. allow training reaction notebook to handle reactions without gas phas… 

    …e kinetics
    @mjohnson541 @rwest
    mjohnson541 authored and rwest committed Jun 14, 2024
    Configuration menu
    Copy the full SHA
    e641798 View commit details
    Browse the repository at this point in the history

  86. fix arrhenius test

    @mjohnson541 @rwest
    mjohnson541 authored and rwest committed Jun 14, 2024
    Configuration menu
    Copy the full SHA
    09fcdee View commit details
    Browse the repository at this point in the history

  87. Fix ArrheniusBM.get_activation_energy unit test. 

    The E0 had been changed, but the expected Ea not updated.
    @rwest
    rwest committed Jun 14, 2024
    Configuration menu
    Copy the full SHA
    a1d77dd View commit details
    Browse the repository at this point in the history

  88. modifed arrbm fit_to_data unit test 

    Test now compares the fitted rate to the rate it was trained on to make sure they agree.
    @davidfarinajr @rwest
    davidfarinajr authored and rwest committed Jun 14, 2024
    Configuration menu
    Copy the full SHA
    c12493f View commit details
    Browse the repository at this point in the history

  89. port arrheniusTest changes to pytest

    @JacksonBurns @rwest
    JacksonBurns authored and rwest committed Jun 14, 2024
    Configuration menu
    Copy the full SHA
    7ff526d View commit details
    Browse the repository at this point in the history

  90. add is_lithium to fragment

    @mjohnson541 @rwest
    mjohnson541 authored and rwest committed Jun 14, 2024
    Configuration menu
    Copy the full SHA
    ba3545f View commit details
    Browse the repository at this point in the history

  91. handle charge properly in fragment smiles hack

    @mjohnson541 @rwest
    mjohnson541 authored and rwest committed Jun 14, 2024
    Configuration menu
    Copy the full SHA
    6d64e75 View commit details
    Browse the repository at this point in the history

  92. skip nodes that are empty when pulling solute data

    @mjohnson541 @rwest
    mjohnson541 authored and rwest committed Jun 14, 2024
    Configuration menu
    Copy the full SHA
    70002c9 View commit details
    Browse the repository at this point in the history

  93. update product template after generation

    @mjohnson541 @rwest
    mjohnson541 authored and rwest committed Jun 14, 2024
    Configuration menu
    Copy the full SHA
    31390b6 View commit details
    Browse the repository at this point in the history

  94. add Li adsorption to test data

    @mjohnson541 @rwest
    mjohnson541 authored and rwest committed Jun 14, 2024
    Configuration menu
    Copy the full SHA
    bc719e7 View commit details
    Browse the repository at this point in the history

  95. add adsorptionLi.py to testing database

    @mjohnson541 @rwest
    mjohnson541 authored and rwest committed Jun 14, 2024
    Configuration menu
    Copy the full SHA
    367aeaa View commit details
    Browse the repository at this point in the history

  96. don't check collision limit for reactions without kinetics

    @mjohnson541 @rwest
    mjohnson541 authored and rwest committed Jun 14, 2024
    Configuration menu
    Copy the full SHA
    0b8f256 View commit details
    Browse the repository at this point in the history

  97. fix charge handling in make sample molecule

    @mjohnson541 @rwest
    mjohnson541 authored and rwest committed Jun 14, 2024
    Configuration menu
    Copy the full SHA
    92f8411 View commit details
    Browse the repository at this point in the history

  98. Refactor some rate fitting in rule generation. 

    It was::

    if n > 1:
        # big long block
    else:
        return None

I inverted the check so we can return early, and outdent a huge block of code.
    @rwest
    rwest committed Jun 14, 2024
    Configuration menu
    Copy the full SHA
    ed5a3c4 View commit details
    Browse the repository at this point in the history

  99. Minor refactor.

    @rwest
    rwest committed Jun 14, 2024
    Configuration menu
    Copy the full SHA
    dba033a View commit details
    Browse the repository at this point in the history

  100. Consistently use T=298. K for fitting and evaluating Blowers-Masel ra… 

    …tes.

Closes #1748
    @rwest
    rwest committed Jun 14, 2024
    Configuration menu
    Copy the full SHA
    dc582bf View commit details
    Browse the repository at this point in the history

  101. Fixes and tweaks to Blowers Masel classes' fit_to_reactions methods.

    @rwest
    rwest committed Jun 14, 2024
    Configuration menu
    Copy the full SHA
    55672f7 View commit details
    Browse the repository at this point in the history

  102. fix atomtype charge checking 

    checks that the first group_atom.atomtype is either an appropriate charged atomtype or is a general version of an appropriate charged atomtype
    @mjohnson541 @rwest
    mjohnson541 authored and rwest committed Jun 14, 2024
    Configuration menu
    Copy the full SHA
    9ed169c View commit details
    Browse the repository at this point in the history

  103. allow cat of regression diff to fail, print a warning instead 

    this will allow the regression test results to all be reported even if there is such a huge difference between the dynamic and baseline that the system utilities cannot print it

see: #2316 (comment)
    @JacksonBurns @rwest
    JacksonBurns authored and rwest committed Jun 14, 2024
    Configuration menu
    Copy the full SHA
    b144463 View commit details
    Browse the repository at this point in the history

  104. combine the messy Cython declarations (and remove dupes) in reaction.py

    @JacksonBurns @rwest
    JacksonBurns authored and rwest committed Jun 14, 2024
    Configuration menu
    Copy the full SHA
    85719a0 View commit details
    Browse the repository at this point in the history

  105. include changes to corrTest - lost in rebase somehow

    @JacksonBurns @rwest
    JacksonBurns authored and rwest committed Jun 14, 2024
    Configuration menu
    Copy the full SHA
    ca35fc4 View commit details
    Browse the repository at this point in the history

  106. change from unittest assert style to pytest

    @JacksonBurns @rwest
    JacksonBurns authored and rwest committed Jun 14, 2024
    Configuration menu
    Copy the full SHA
    d064bf3 View commit details
    Browse the repository at this point in the history

  107. port new test for kinetics families

    @JacksonBurns @rwest
    JacksonBurns authored and rwest committed Jun 14, 2024
    Configuration menu
    Copy the full SHA
    5092a78 View commit details
    Browse the repository at this point in the history

  108. skip a test in solvation 

    see this commit from matt (64bb21a) for why: 64bb21a
    @JacksonBurns @rwest
    JacksonBurns authored and rwest committed Jun 14, 2024
    Configuration menu
    Copy the full SHA
    1a02be9 View commit details
    Browse the repository at this point in the history

  109. port surface test to new file and style

    @JacksonBurns @rwest
    JacksonBurns authored and rwest committed Jun 14, 2024
    Configuration menu
    Copy the full SHA
    20f8802 View commit details
    Browse the repository at this point in the history

  110. port atom type test to new style and file

    @JacksonBurns @rwest
    JacksonBurns authored and rwest committed Jun 14, 2024
    Configuration menu
    Copy the full SHA
    2718a34 View commit details
    Browse the repository at this point in the history

  111. change moleculeTest to pytest style

    @JacksonBurns @rwest
    JacksonBurns authored and rwest committed Jun 14, 2024
    Configuration menu
    Copy the full SHA
    716f206 View commit details
    Browse the repository at this point in the history

  112. port groupTest to pytest

    @JacksonBurns @rwest
    JacksonBurns authored and rwest committed Jun 14, 2024
    Configuration menu
    Copy the full SHA
    b9a31e1 View commit details
    Browse the repository at this point in the history

  113. move database test files, port tests and update style

    @JacksonBurns @rwest
    JacksonBurns authored and rwest committed Jun 14, 2024
    Configuration menu
    Copy the full SHA
    0f1d5de View commit details
    Browse the repository at this point in the history

  114. pytest.skip -> pytest.mark.skip

    @JacksonBurns @rwest
    JacksonBurns authored and rwest committed Jun 14, 2024
    Configuration menu
    Copy the full SHA
    d8da334 View commit details
    Browse the repository at this point in the history

  115. add a missing kwarg to fragment's overloaded update function 

    note that it is ignored however
    @JacksonBurns @rwest
    JacksonBurns authored and rwest committed Jun 14, 2024
    Configuration menu
    Copy the full SHA
    35c65f8 View commit details
    Browse the repository at this point in the history

  116. remove deprecated check for nose test

    @JacksonBurns @rwest
    JacksonBurns authored and rwest committed Jun 14, 2024
    Configuration menu
    Copy the full SHA
    82e5c76 View commit details
    Browse the repository at this point in the history

  117. bad automated conversion of assert equal

    @JacksonBurns @rwest
    JacksonBurns authored and rwest committed Jun 14, 2024
    Configuration menu
    Copy the full SHA
    a40003a View commit details
    Browse the repository at this point in the history

  118. missed some unittest-style assert + copied some tests into wrong class

    @JacksonBurns @rwest
    JacksonBurns authored and rwest committed Jun 14, 2024
    Configuration menu
    Copy the full SHA
    8edd5cb View commit details
    Browse the repository at this point in the history

  119. add missing kwarg to fragment update method

    @JacksonBurns @rwest
    JacksonBurns authored and rwest committed Jun 14, 2024
    Configuration menu
    Copy the full SHA
    2928b95 View commit details
    Browse the repository at this point in the history

  120. TEMPORARY: set database branch to lithium 

    remove this commit before merging
    @mjohnson541 @rwest
    mjohnson541 authored and rwest committed Jun 14, 2024
    Configuration menu
    Copy the full SHA
    b8462a5 View commit details
    Browse the repository at this point in the history

  121. enable fitting of TS solute rules

    @mjohnson541 @rwest
    mjohnson541 authored and rwest committed Jun 14, 2024
    Configuration menu
    Copy the full SHA
    42834fb View commit details
    Browse the repository at this point in the history

  122. set database branch to lithium

    @mjohnson541 @rwest
    mjohnson541 authored and rwest committed Jun 14, 2024
    Configuration menu
    Copy the full SHA
    fc2289e View commit details
    Browse the repository at this point in the history

  123. fix charge handling in make sample molecule

    @mjohnson541 @rwest
    mjohnson541 authored and rwest committed Jun 14, 2024
    Configuration menu
    Copy the full SHA
    0469e71 View commit details
    Browse the repository at this point in the history

  124. allow inclusion of refractive index in Solvent object

    @mjohnson541 @rwest
    mjohnson541 authored and rwest committed Jun 14, 2024
    Configuration menu
    Copy the full SHA
    3b7428e View commit details
    Browse the repository at this point in the history

  125. change TS solvation handling to new system

    @mjohnson541 @rwest
    mjohnson541 authored and rwest committed Jun 14, 2024
    Configuration menu
    Copy the full SHA
    1ff5641 View commit details
    Browse the repository at this point in the history

  126. add Marcus kinetics

    @mjohnson541 @rwest
    mjohnson541 authored and rwest committed Jun 14, 2024
    Configuration menu
    Copy the full SHA
    54f1b98 View commit details
    Browse the repository at this point in the history

  127. handle Marcus kinetics in the RMS reactors

    @mjohnson541 @rwest
    mjohnson541 authored and rwest committed Jun 14, 2024
    Configuration menu
    Copy the full SHA
    23f9561 View commit details
    Browse the repository at this point in the history

  128. fix bug with species initialization

    @mjohnson541 @rwest
    mjohnson541 authored and rwest committed Jun 14, 2024
    Configuration menu
    Copy the full SHA
    23b60ef View commit details
    Browse the repository at this point in the history

  129. allow direct specification of viscosity and electrode distance for th… 

    …e RMS reactor
    @mjohnson541 @rwest
    mjohnson541 authored and rwest committed Jun 14, 2024
    Configuration menu
    Copy the full SHA
    fd0c0b6 View commit details
    Browse the repository at this point in the history

  130. properly handle electronchange when constructing RMS reaction objects

    @mjohnson541 @rwest
    mjohnson541 authored and rwest committed Jun 14, 2024
    Configuration menu
    Copy the full SHA
    9048d6a View commit details
    Browse the repository at this point in the history

  131. add epsilon_0 to constants

    @mjohnson541 @rwest
    mjohnson541 authored and rwest committed Jun 14, 2024
    Configuration menu
    Copy the full SHA
    1ebcf5a View commit details
    Browse the repository at this point in the history

  132. handle Marcus in RMS yaml constructionn

    @mjohnson541 @rwest
    mjohnson541 authored and rwest committed Jun 14, 2024
    Configuration menu
    Copy the full SHA
    6adea6e View commit details
    Browse the repository at this point in the history

  133. specify electronchange in RMS yaml construction

    @mjohnson541 @rwest
    mjohnson541 authored and rwest committed Jun 14, 2024
    Configuration menu
    Copy the full SHA
    275317c View commit details
    Browse the repository at this point in the history

  134. handle Marcus kinetics in fix_barrier_height

    @mjohnson541 @rwest
    mjohnson541 authored and rwest committed Jun 14, 2024
    Configuration menu
    Copy the full SHA
    ac40b74 View commit details
    Browse the repository at this point in the history

  135. handle solvation for Marcus kinetics for library reactions

    @mjohnson541 @rwest
    mjohnson541 authored and rwest committed Jun 14, 2024
    Configuration menu
    Copy the full SHA
    f8207d1 View commit details
    Browse the repository at this point in the history

  136. allow Marcus kinetics to be loaded

    @mjohnson541 @rwest
    mjohnson541 authored and rwest committed Jun 14, 2024
    Configuration menu
    Copy the full SHA
    e9415da View commit details
    Browse the repository at this point in the history

  137. alllow Marcus kinetics in families

    @mjohnson541 @rwest
    mjohnson541 authored and rwest committed Jun 14, 2024
    Configuration menu
    Copy the full SHA
    cbdaf10 View commit details
    Browse the repository at this point in the history

  138. handle solvation for Marcus kinetics in families

    @mjohnson541 @rwest
    mjohnson541 authored and rwest committed Jun 14, 2024
    Configuration menu
    Copy the full SHA
    82a0ecc View commit details
    Browse the repository at this point in the history

  139. handle kinetics averaging for Marcus

    @mjohnson541 @rwest
    mjohnson541 authored and rwest committed Jun 14, 2024
    Configuration menu
    Copy the full SHA
    8ba9ee6 View commit details
    Browse the repository at this point in the history

  140. squash

    @mjohnson541 @rwest
    mjohnson541 authored and rwest committed Jun 14, 2024
    Configuration menu
    Copy the full SHA
    6ea8506 View commit details
    Browse the repository at this point in the history

  141. handle Marcus kinetics within tree generation and rule generation

    @mjohnson541 @rwest
    mjohnson541 authored and rwest committed Jun 14, 2024
    Configuration menu
    Copy the full SHA
    d0be040 View commit details
    Browse the repository at this point in the history

  142. add ethylene carbonate example

    @mjohnson541 @rwest
    mjohnson541 authored and rwest committed Jun 14, 2024
    Configuration menu
    Copy the full SHA
    bc482a2 View commit details
    Browse the repository at this point in the history

  143. add acetonitrile SEI chemistry example

    @mjohnson541 @rwest
    mjohnson541 authored and rwest committed Jun 14, 2024
    Configuration menu
    Copy the full SHA
    9740a93 View commit details
    Browse the repository at this point in the history

  144. Fixed a typo in test lose charge

    @ssun30 @rwest
    ssun30 authored and rwest committed Jun 14, 2024
    Configuration menu
    Copy the full SHA
    1f19a01 View commit details
    Browse the repository at this point in the history

  145. Fixed syntax problems with SEI examples

    @ssun30 @rwest
    ssun30 authored and rwest committed Jun 14, 2024
    Configuration menu
    Copy the full SHA
    1e09890 View commit details
    Browse the repository at this point in the history

  146. Add set_reference_potential for SurfaceChargeTransfer 

    in to_rms
    @ssun30 @rwest
    ssun30 authored and rwest committed Jun 14, 2024
    Configuration menu
    Copy the full SHA
    7cdc823 View commit details
    Browse the repository at this point in the history

  147. Fixed atomtype charge checking 

    Now includes checks for negative charges

temporary fix to an exponent overflow problem
    @ssun30 @rwest
    ssun30 authored and rwest committed Jun 14, 2024
    Configuration menu
    Copy the full SHA
    f4288be View commit details
    Browse the repository at this point in the history

  148. Fixed A-factor correction for SurfaceChargeTransfer 

    Added solvent correction for SurfaceChargeTransfer
    @ssun30 @rwest
    ssun30 authored and rwest committed Jun 14, 2024
    Configuration menu
    Copy the full SHA
    d6193e2 View commit details
    Browse the repository at this point in the history

  149. Changed RMS branch to marcus for CI

    @ssun30 @rwest
    ssun30 authored and rwest committed Jun 14, 2024
    Configuration menu
    Copy the full SHA
    9bc0dc9 View commit details
    Browse the repository at this point in the history