Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update entropy of triplet oxygen atom #338

Merged
merged 1 commit into from
Jun 14, 2019
Merged

Conversation

cgrambow
Copy link

@cgrambow cgrambow commented Jun 14, 2019

The entropy of the oxygen atom in the primary thermo library is incorrect because it is missing the contribution of the first and second excited states. See this discussion for more details.

This PR corrects the value.

I would like to be nominated for the shortest PR award.

@alongd
Copy link
Member

alongd commented Jun 14, 2019

image

Copy link
Member

@alongd alongd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@alongd alongd merged commit 0a89224 into master Jun 14, 2019
@alongd alongd deleted the update_oxygen_entropy branch June 14, 2019 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants