Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RMG v2.4.0 (?) Release Planning #1591

Closed
5 tasks
mliu49 opened this issue Apr 29, 2019 · 8 comments
Closed
5 tasks

RMG v2.4.0 (?) Release Planning #1591

mliu49 opened this issue Apr 29, 2019 · 8 comments

Comments

@mliu49
Copy link
Contributor

mliu49 commented Apr 29, 2019

With the RMG-cat merge completed, I think we should have a new release soon. Potential target release date could be end of May. Please feel free to provide your own thoughts.

First, regarding the release number, I'm leaning towards 2.4.0. The RMG-cat merge is a major new feature, but it didn't introduce any backward compatibility issues, so I'm not sure if it would necessitate jumping to 3.0.0. Also, thinking ahead, it would be nice to transition to Python 3 and fix our variable naming inconsistencies for the 3.0.0 release, which would definitely involve breaking changes. Of course, this is also open for discussion.

Next, we need to identify any issues/PRs which we want to include in this release. Potential list:

Please use this issue thread to comment on the status of currently open PRs and whether or not they can/should be included in this release. RMG-database PRs can also be discussed here rather than creating a separate RMG-database issue.

@mliu49
Copy link
Contributor Author

mliu49 commented Apr 29, 2019

Another topic for discussion: Would we like to begin official support for Docker with this release?

For people not in the Green Group who may not know about this, we have been considering Docker as a way to offer a host-independent method of installing RMG. This can be especially useful for installing on HPC clusters which may already have support for Docker images. Somewhat surprisingly, there were already a couple of RMG images on Docker Hub. For testing, I've created a semi-official one which can be pulled: https://hub.docker.com/r/mliu49/rmg.

The main benefit would be offering a streamlined option for running RMG on a wider variety of systems, including non-ubuntu linux systems and windows, at the cost of adding another system which we would need to manage and support.

What this would entail:

  • Finalize dockerfile for building RMG image
  • Develop and document recommended workflow for using RMG via Docker
  • Develop workflow for creating Docker images (ideally automated, but not strictly necessary)

@rwest
Copy link
Member

rwest commented Apr 29, 2019

Docker sounds like a decent idea, (though I'm not volunteering my own time to support it. I think @skrsna has done some docker stuff)

I think 2.4.0 is reasonable. Nice to have 3.0 be the Python 3 version.

May sounds like a good target

@alongd
Copy link
Member

alongd commented Apr 30, 2019

I think we should merge #1496 and ReactionMechanismGenerator/RMG-database#296
Might as well also do #1575, which is small
(all are rebased and should be good to go, #1575 still needs to be reviewed)

@goldmanm
Copy link
Contributor

goldmanm commented May 7, 2019

Is it worthwhile to get in commits necessary for the Arkane paper? Like @mjohnson541 's quantum hindered rotors, and my reorganizing the output of Arkane?

@alongd
Copy link
Member

alongd commented May 7, 2019

I agree, let's try to get it in

@mliu49
Copy link
Contributor Author

mliu49 commented May 15, 2019

RMG-Py v2.4.0 Release Notes (draft)

RMG-database v2.4.0 Release Notes (draft)

(note that the tags here are odd because this issue is in the RMG-Py repo; the final release notes will be in the RMG-database repo so they will be normal)

@mliu49
Copy link
Contributor Author

mliu49 commented May 15, 2019

Please feel free to edit the draft release notes above. I would also appreciate it if everyone could help keep this up to date as we merge more PRs before the release.

@mliu49
Copy link
Contributor Author

mliu49 commented Jun 18, 2019

Release is done!

@mliu49 mliu49 closed this as completed Jun 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants
@rwest @mliu49 @goldmanm @alongd and others