Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes to CI #112

Merged
merged 3 commits into from
Apr 22, 2023
Merged

Changes to CI #112

merged 3 commits into from
Apr 22, 2023

Conversation

calvinp0
Copy link
Member

Breaking up the CI for better control

@codecov-commenter
Copy link

codecov-commenter commented Apr 22, 2023

Codecov Report

Merging #112 (710faf2) into main (2de3b76) will decrease coverage by 0.07%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #112      +/-   ##
==========================================
- Coverage   73.46%   73.40%   -0.07%     
==========================================
  Files          22       22              
  Lines        2891     2891              
  Branches      762      762              
==========================================
- Hits         2124     2122       -2     
- Misses        552      553       +1     
- Partials      215      216       +1     
Flag Coverage Δ
unittests 73.40% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
t3/settings/t3_submit.py 100.00% <ø> (ø)

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@calvinp0 calvinp0 force-pushed the CI_Improvement branch 2 times, most recently from c759bce to 0cc522e Compare April 22, 2023 16:00
@calvinp0 calvinp0 requested a review from alongd April 22, 2023 16:02
Copy link
Member

@alongd alongd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Added a few questions

OLDcont_int.yml Outdated
@@ -0,0 +1,135 @@
name: CI
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to save the OLD file? (it's also always accessible through git)

t3/runners/rmg_runner.py Outdated Show resolved Hide resolved
t3/runners/rmg_runner.py Outdated Show resolved Hide resolved
.github/update_cache.yml Outdated Show resolved Hide resolved
CI is now broken into multiple steps to allow for the ability to cache
This improves run time by 50 mins, assuming the cache exists
This will run ever 7 days to update the cache in the repo so that we ensure we are always up-to-date on the latest branches for other repos
Now using $rmgpy_path as this way a user can define it in their bashrc where RMG-Py is located in their system. This is reflected in the submit file
Also, tests have been updated
@calvinp0 calvinp0 reopened this Apr 22, 2023
Copy link
Member

@alongd alongd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!!

@calvinp0 calvinp0 merged commit 70e3921 into main Apr 22, 2023
@calvinp0 calvinp0 deleted the CI_Improvement branch April 22, 2023 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants