Document major differences from Rx #265
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| # Differences from Rx | ||
|
|
||
| ReactiveCocoa is significantly inspired by .NET's [Reactive | ||
| Extensions](http://msdn.microsoft.com/en-us/data/gg577609.aspx), but it is not |
There was a problem hiding this comment.
Since you refer to Reactive Extensions later as "Rx", it might be good to put that in parens or something?
ghost
assigned 
|
A couple notes. All the correspondences look right to me. I'll let this chill for a bit to see if any of the pinged people have any comments. |
| @@ -129,6 +131,8 @@ | |||
| // If an error occurs on any of the signals, it is sent on the returned signal. | |||
| // It completes only after the receiver and all sent signals have completed. | |||
| // | |||
| // This corresponds to the `Merge()` method in Rx. | |||
There was a problem hiding this comment.
You should specify which Merge here (there are several overloads), I think the one that corresponds to this one is Merge<T>(this IObservable<IObservable<T>> source)
|
🍔 Thanks @xpaulbettsx! |
|
💥 🚱 |
joshaber
added a commit
that referenced
this pull request
Jan 8, 2013
Document major differences from Rx
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes per-method documentation where names differ, and a new Differences from Rx document, which tries to cover high-level differences.
Completes #176.
@andrask @cwharris @xpaulbettsx @haacked @half-ogre @aroben I'd appreciate it if someone more familiar with Rx could fact-check this, or point out anything major I missed. ✨