Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

watchOS support #2121

Closed
wants to merge 11 commits into from
Closed

Conversation

MarcoSero
Copy link
Contributor

This PR is against the protocol extensions branch.

  • watchOS target successfully building
  • watchOSTests passing all tests

Quick does not seem to support watchOS at the moment.

UPDATE: unfortunately the watchOS test target can't be added until Apple fixes rdar://21760513

@@ -0,0 +1,19 @@
//
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should be able to use the same shared header as the iOS and Mac targets.

@neilpa
Copy link
Member

neilpa commented Jun 23, 2015

Some comments around the build setup.

@MarcoSero
Copy link
Contributor Author

Thanks @neilpa for reviewing .xcodeproj files. I know it's not fun.
I'm planning to tackle Quick/Quick#333 next so that I can add the test target.

@neilpa
Copy link
Member

neilpa commented Jun 24, 2015

Cool, I know making build changes also isn't fun.

@JaviSoto
Copy link
Member

Any updates @MarcoSero? :)

@MarcoSero
Copy link
Contributor Author

Sorry I was on holiday for the past couple of weeks. I need to find some time to add watchOS support to Quick/Quick#333

@MarcoSero
Copy link
Contributor Author

Unfortunately the watchOS test target can't be added yet (see rdar://21760513)

@JARinteractive opened the same PR #2206 . We can merge his or mine, I just need to rebase on top of the latest Swift 2 branch.

@MarcoSero
Copy link
Contributor Author

Squashed commits and opened a new PR targeting swift2 #2209

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants