Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let's test ReactiveCocoa for tvOS 📺 #2868

Merged
merged 1 commit into from
May 6, 2016

Conversation

dmcrodrigues
Copy link
Contributor

@dmcrodrigues dmcrodrigues commented May 5, 2016

Suggested in #2864. Depends on #2867 to be fully integrated with Travis.

PRODUCT_NAME = "$(PROJECT_NAME)Tests";
SDKROOT = appletvos;
SWIFT_OPTIMIZATION_LEVEL = "-Onone";
TVOS_DEPLOYMENT_TARGET = 9.2;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you remove this to inherit the value in the xcconfig?

@NachoSoto
Copy link
Member

NachoSoto commented May 5, 2016

Thank you! <3

One day setting this up won't require a whole copy of a target and scheme. One day...

@dmcrodrigues
Copy link
Contributor Author

I eagerly expect for that day! Thanks for catching this @NachoSoto

@ikesyo ikesyo merged commit 0bcf912 into ReactiveCocoa:master May 6, 2016
@ikesyo
Copy link
Member

ikesyo commented May 6, 2016

Thanks @dmcrodrigues! I've merged this into master with some modifications (diff). 🚀

@mdiep
Copy link
Contributor

mdiep commented May 6, 2016

Wanna do the same thing for watchOS? 😄

@ikesyo
Copy link
Member

ikesyo commented May 6, 2016

We cannot have a test target for watchOS unfortunately. 😢

@mdiep
Copy link
Contributor

mdiep commented May 6, 2016

We cannot have a test target for watchOS unfortunately.

Why is that?

@ikesyo
Copy link
Member

ikesyo commented May 6, 2016

Xcode does not have a template for watchOS test target, and also Quick doesn't have watchOS support. See #2121 and Quick/Quick#333.

@dmcrodrigues dmcrodrigues deleted the add-tvOS-test-target branch May 6, 2016 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants