Create ReactiveSwift and ReactiveSwiftTests targets #2980

eimantas · 2016-06-12T16:11:38Z

Adjust import statement based on compiled target
Extract DynamicProperty (and its specs) to separate file and add it to mac targets
Swift files are still shared among ReactiveSwift and other targets

mdiep · 2016-06-19T02:10:31Z

The ReactiveSwift target doesn't build for me. 😕

We also need watchOS, iOS, and tvOS targets. And it'd be a good idea to add these things to the build matrix on Travis. That will be large for a while, but it's only temporary.

mdiep · 2016-06-19T02:11:53Z

Can you also set the xcconfigs for these targets?

eimantas · 2016-06-19T06:12:34Z

I'm not really god with configs so I defined generic "Framework" and "Application" defines for the framework and unit tests' targets appropriately.

We also need watchOS, iOS, and tvOS targets.

Do you mean "ReactiveSwift-watchOS", "ReactiveSwift-iOS" and "ReactiveSwift-tvOS"?

eimantas · 2016-06-19T07:02:28Z

The target now builds. A couple of tests started failing (probably a fluke?).

andersio · 2016-07-02T15:34:31Z

@eimantas We need a target for each of the four OSes. The ReactiveSwift target in this branch is just for Mac.

eimantas · 2016-07-02T15:36:08Z

Got it. I'll add the missing ones then. How would I go adding these now that the RAC5 is imminent with changes for Property? I should probably try and rebase...

andersio · 2016-07-02T15:42:06Z

You can just focus on getting these items right. Those changes would be taken care of when they are landed in master, eh, eventually. 😸

eimantas · 2016-07-02T19:46:58Z

The targets are all there. There are few main points though:

~~I can't seem to get the ReactiveSwift-iOSTests to build properly. All good with mac and tvOS.~~
The target name in all four targets is hardcoded to ReactiveSwift as other targets use$(PROJECT_NAME) which resolves to ReactiveCocoa
I've added -D REACTIVE_SWIFT to Other Swift Flags in order for the swift files to correctly compile for both - ReactiveCocoa and ReactiveSwift targets.

mdiep · 2016-07-05T01:37:35Z

CI didn't run for some reason. 😕

There are also some conflicts. Want to resolve them and hopefully that will trigger CI?

- Adjust import statement based on compiled target - Extract `DynamicProperty` to separate file and add it to mac targets

Also update `Result` and `Nimble` submodules

- ReactiveSwift-Mac -> ReactiveSwift - Add ReactiveSwift-iOS. Product: ReactiveSwift Note: the "ReactiveSwift" value is hardcoded and does not come from any build environment variable (unlike for ReactiveCocoa-X products).

Also add `-D REACTIVE_SWIFT` flag to all configurations of `ReactiveSwift` targets

eimantas · 2016-07-05T06:11:39Z

Seems to be working now.

eimantas · 2016-07-05T10:06:03Z

Things still missing:

No xcconfig changes;
I am not sure how to add new targets to CI travis (probably don't have the permissions to that anyway);

mdiep · 2016-07-05T12:28:44Z

I am not sure how to add new targets to CI travis (probably don't have the permissions to that anyway);

You do have permissions! Edit .travis.yml. The configuration is versioned with the repository!

ikesyo · 2016-07-05T14:51:54Z

ReactiveCocoa.xcodeproj/xcshareddata/xcschemes/ReactiveSwift-iOS.xcscheme

+            buildForRunning = "YES"
+            buildForProfiling = "YES"
+            buildForArchiving = "YES"
+            buildForAnalyzing = "YES">


Only buildForTesting should be YES since this is a testing dependency.

ikesyo · 2016-07-05T15:22:02Z

ReactiveCocoa.xcodeproj/project.pbxproj

+			name = Debug;
+		};
+		530F8B8A1D0DB70B00009C2C /* Test */ = {
+			isa = XCBuildConfiguration;


Please set Mac-Application xcconfig.

mdiep · 2016-07-20T00:45:55Z

It looks like some of @ikesyo's notes above are still unaddressed.

Additionally, CI is failing because the upstream changes changed .travis.yml to build with both Xcode 7 and Xcode 8. This will require some changes here, but also gives us the opportunity to add Xcode 8 builds for ReactiveSwift as well.

mdiep · 2016-08-16T21:54:15Z

Superseded by #3137.

eimantas changed the title ~~Create ReactiveSwift and ReactiveSwiftTests target~~ Create ReactiveSwift and ReactiveSwiftTests targets Jun 13, 2016

Eimantas Vaiciunas added 9 commits July 5, 2016 08:31

Create ReactiveSwift and ReactiveSwiftTests target

b72aa6a

- Adjust import statement based on compiled target - Extract `DynamicProperty` to separate file and add it to mac targets

Make import statement indentation consistent

818701c

Move REACTIVE_SWIFT define to proper place

775ebc9

Rename ReactiveSwift to ReactiveSwift-Mac

f3236e0

Also update `Result` and `Nimble` submodules

Add -Mac suffix to ReactiveSwift targets

28e7ec2

Add iOS target and rename build products

641e99d

- ReactiveSwift-Mac -> ReactiveSwift - Add ReactiveSwift-iOS. Product: ReactiveSwift Note: the "ReactiveSwift" value is hardcoded and does not come from any build environment variable (unlike for ReactiveCocoa-X products).

Fix iOS target and create watchOS target

d3e5ee8

Also add `-D REACTIVE_SWIFT` flag to all configurations of `ReactiveSwift` targets

Add tvOS target and scheme

9fca040

Fix the unit tests for iOS platform

745ba07

Add ReactiveSwift schemes to .travis.yml

c31decc

ikesyo reviewed Jul 5, 2016
View reviewed changes

Eimantas Vaiciunas added 3 commits July 13, 2016 21:36

Updates according to @ikesyo notes

0bc3156

Fix accidental typo

45a0de0

Resolve conflicts with upstream

871c98e

mdiep mentioned this pull request Aug 16, 2016

Create ReactiveSwift.framework #3137

Merged

mdiep closed this Aug 16, 2016

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Create ReactiveSwift and ReactiveSwiftTests targets #2980

Create ReactiveSwift and ReactiveSwiftTests targets #2980

eimantas commented Jun 12, 2016

mdiep commented Jun 19, 2016

mdiep commented Jun 19, 2016

eimantas commented Jun 19, 2016

eimantas commented Jun 19, 2016

andersio commented Jul 2, 2016

eimantas commented Jul 2, 2016

andersio commented Jul 2, 2016 •

edited

eimantas commented Jul 2, 2016 •

edited

mdiep commented Jul 5, 2016

eimantas commented Jul 5, 2016

eimantas commented Jul 5, 2016

mdiep commented Jul 5, 2016

ikesyo Jul 5, 2016

ikesyo Jul 5, 2016

mdiep commented Jul 20, 2016

mdiep commented Aug 16, 2016

Create ReactiveSwift and ReactiveSwiftTests targets #2980

Create ReactiveSwift and ReactiveSwiftTests targets #2980

Conversation

eimantas commented Jun 12, 2016

mdiep commented Jun 19, 2016

mdiep commented Jun 19, 2016

eimantas commented Jun 19, 2016

eimantas commented Jun 19, 2016

andersio commented Jul 2, 2016

eimantas commented Jul 2, 2016

andersio commented Jul 2, 2016 • edited

eimantas commented Jul 2, 2016 • edited

mdiep commented Jul 5, 2016

eimantas commented Jul 5, 2016

eimantas commented Jul 5, 2016

mdiep commented Jul 5, 2016

ikesyo Jul 5, 2016

Choose a reason for hiding this comment

ikesyo Jul 5, 2016

Choose a reason for hiding this comment

mdiep commented Jul 20, 2016

mdiep commented Aug 16, 2016

andersio commented Jul 2, 2016 •

edited

eimantas commented Jul 2, 2016 •

edited