Create ReactiveSwift.framework #3137
Conversation
| @@ -11,7 +11,7 @@ script: | |||
| xcode_workspace: ReactiveCocoa.xcworkspace | |||
| matrix: | |||
| include: | |||
| - xcode_scheme: ReactiveCocoa-Mac | |||
| - xcode_scheme: ReactiveCocoa-macOS | |||
|
Feedback is addressed. Tests don't pass on CI because Travis was updating to ß6. |
# Conflicts: # ReactiveCocoa/Swift/Lifetime.swift # ReactiveSwiftTests/PropertySpec.swift
| let package = Package( | ||
| name: "ReactiveCocoa", | ||
| name: "ReactiveSwift", |
There was a problem hiding this comment.
Shouldn't we have two packages here?
There was a problem hiding this comment.
- I'm not sure if a package for ReactiveCocoa is useful
- I couldn't find how to make write a
Package.swiftto make multiple packages or use intra-repository dependencies
If this is something we want, I think we should add it back when ReactiveSwift is moved to its own repo.
|
SwiftPM build is broken 😞 https://travis-ci.org/ReactiveCocoa/ReactiveCocoa/jobs/154453152 This symlink should be changed. |
|
This is ready to go! 🎉 The carthage build is having some trouble due to timeouts on Travis, but this should get better as we split up the repos. |
This should help with timeout issues on Travis.
|
@ReactiveCocoa/reactivecocoa Anyone want to review this? 😄 |
|
I have this in my TODO list! |
|
Should we consider re-exporting |
I think we should wait until it's a stable feature. |
# Conflicts: # ReactiveCocoa.xcodeproj/project.pbxproj # ReactiveCocoa/Swift/Lifetime.swift # ReactiveSwiftTests/PropertySpec.swift
# Conflicts: # Carthage/Checkouts/Nimble # Carthage/Checkouts/Quick
|
I'll self-merge this at the end of the week if no one has reviewed it before then. 😄 |
| } | ||
| } | ||
| } | ||
|
|
||
| #if os(macOS) || os(iOS) || os(tvOS) || os(watchOS) |
There was a problem hiding this comment.
This isn't necessary, since Objective-C is present on all Darwin platforms.
|
May you reorder the schemes please? By the way, |
| @@ -1,6 +1,6 @@ | |||
| import Quick | |||
| import Nimble | |||
| import ReactiveCocoa | |||
| import ReactiveSwift | |||
| import Result | |||
|
|
|||
| final class LifetimeSpec: QuickSpec { | |||
There was a problem hiding this comment.
The description perhaps should be changed, and I wonder if the test cases should be duplicated for NSObject.rac_lifetime in ReactiveCocoa.
|
|
# Conflicts: # ReactiveCocoa.xcodeproj/project.pbxproj
Schemes ordering is a local thing AFAIK. It's not affected by anything here. (All my schemes are ordered correctly.)
Probably, but I think that's beyond the scope of this PR.
We'll have to fix that post-split. |
| isa = PBXSourcesBuildPhase; | ||
| buildActionMask = 2147483647; | ||
| files = ( | ||
| D08C54B41A69A2AF00AD8286 /* Signal.swift in Sour |
There was a problem hiding this comment.
Can you remove this setting to favor the .xcconfig?
There was a problem hiding this comment.
Which settings? GitHub seems to have misplaced your comment.
|
Just a couple of comments, but I think this is ready! |
|
Okay, I'm planning to merge this in ~24 hours. (Unless anyone speaks up.) At that point, I'll push a copy to https://github.com/ReactiveCocoa/ReactiveSwift/, make it public, and open a PR to remove the RAC bits. I'll probably merge it right away. Then I'll open a PR to RAC to make it depend on ReactiveSwift and continue by going through this same process with ReactiveObjC and ReactiveObjCBridge. |
|
🎉 |
Supersedes #2980.
This introduces
ReactiveSwift.framework. I've done this as a PR here to allow the changes to be reviewed. Once merged, I will clone this repo, remove RAC, and push to ReactiveSwift. I will then open a PR to update this repo to get ReactiveSwift as a submodule.Of note: I first duplicated the ReactiveCocoa files and then deleted files from each framework.