Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Carthage xcconfigs to 1.1 #3728

Merged
merged 11 commits into from
Sep 4, 2021
Merged

Update Carthage xcconfigs to 1.1 #3728

merged 11 commits into from
Sep 4, 2021

Conversation

iby
Copy link
Contributor

@iby iby commented Jun 18, 2021

This allows building Carthage XCFrameworks with support for Apple Silicone. This is a counterpart for ReactiveCocoa/ReactiveSwift#832 – once that is accepted also need to update ReactiveSwift to latest.

Checklist

  • Updated CHANGELOG.md.

@iby
Copy link
Contributor Author

iby commented Jun 18, 2021

@andersio can we review this and the ReactiveSwift PR and make a patch release to allow proper Apple Silicon XCFramework building via Carthage? 🙏

@iby
Copy link
Contributor Author

iby commented Jun 19, 2021

@andersio approve CI please.

@iby iby mentioned this pull request Jun 20, 2021
Merged
1 task
@andersio
Copy link
Member

Do the newer xcconfigs have warnings as error enabled by any chance?

@iby
Copy link
Contributor Author

iby commented Jun 23, 2021

Definitely know that TREAT_WARNINGS_AS_ERRORS come enabled for both Swift and GCC lately as default, but don't think that has changed in xcconfigs, not since 2019 – been upgrading all of my projects to disable it lately.

@iby
Copy link
Contributor Author

iby commented Jun 23, 2021

Yep. There's a few deprecations and tests would fail because of that. Plus a few warnings. Gonna do some tidying up.

@iby
Copy link
Contributor Author

iby commented Jun 24, 2021

@andersio Yep. ReactiveSwift already has them all disabled. Did the same for ReactiveCocoa, updated dependencies and did the same tidying up as per ReactiveCocoa/ReactiveSwift#833.

@iby
Copy link
Contributor Author

iby commented Jun 28, 2021

@andersio a polite bump.

@iby
Copy link
Contributor Author

iby commented Sep 3, 2021

@andersio more polite Friday bumping! 👋

@andersio andersio merged commit 47672fa into ReactiveCocoa:master Sep 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
ci:verify
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@iby @andersio