Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Buffer operators #120

Merged
merged 6 commits into from Dec 4, 2018
Merged

Buffer operators #120

merged 6 commits into from Dec 4, 2018

Conversation

teivah
Copy link
Member

@teivah teivah commented Dec 4, 2018

Buffer operators (using a signature very close to #36 (comment)):

  • BufferWithCount
  • BufferWithTime
  • BufferWithTimeOrCount
  • Race condition fix

@teivah teivah mentioned this pull request Dec 4, 2018
Merged
@coveralls
Copy link

Pull Request Test Coverage Report for Build 249

  • 224 of 226 (99.12%) changed or added relevant lines in 4 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+1.2%) to 90.4%
Changes Missing Coverage Covered Lines Changed/Added Lines %
observer.go 19 21 90.48%
Totals Coverage Status
Change from base Build 240: 1.2%
Covered Lines: 1516
Relevant Lines: 1677
💛 - Coveralls

@avelino avelino self-requested a review December 4, 2018 18:08
@avelino avelino added the version 2 RxGo v2. label Dec 4, 2018
@avelino avelino added this to the version 2 milestone Dec 4, 2018
@teivah teivah merged commit dbb48a5 into v2 Dec 4, 2018
@avelino avelino deleted the v2-buffer branch December 4, 2018 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@avelino avelino Awaiting requested review from avelino

Assignees
No one assigned
Labels
version 2 RxGo v2.
Projects
None yet
Milestone
version 2
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@teivah @coveralls @avelino