Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

StartWith operator #157

Merged
merged 2 commits into from
Dec 10, 2018
Merged

StartWith operator #157

merged 2 commits into from
Dec 10, 2018

Conversation

teivah
Copy link
Member

@teivah teivah commented Dec 4, 2018

StartWith operator implementation:

  • StartWithItems to start from a list of items
  • StartWithIterable to start from a given Iterable
  • StartWithObservable to start from a given Observable

Reference: http://reactivex.io/documentation/operators/startwith.html
Related issue: #135

@teivah teivah added this to the version 2 milestone Dec 4, 2018
@teivah teivah requested a review from avelino December 4, 2018 21:19
Merge branch 'v2' into issue_135
54a073b 
# Conflicts:
#	observable.go
#	observable_test.go
@coveralls
Copy link

coveralls commented Dec 4, 2018 •
edited
Loading

Pull Request Test Coverage Report for Build 258

  • 48 of 48 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.1%) to 96.168%
Totals Coverage Status
Change from base Build 256: 0.1%
Covered Lines: 1556
Relevant Lines: 1618
💛 - Coveralls

@teivah teivah mentioned this pull request Dec 10, 2018
Merged
@avelino avelino merged commit 6007666 into v2 Dec 10, 2018
@avelino avelino deleted the issue_135 branch December 10, 2018 18:36
@avelino avelino restored the issue_135 branch December 10, 2018 18:50
@avelino avelino mentioned this pull request Dec 10, 2018
Closed
avelino added a commit that referenced this pull request Dec 10, 2018
@avelino
Revert "StartWith operator. Minor test migration to use assertion API. (
30164ac 
#157)"

This reverts commit 6007666.
@teivah teivah deleted the issue_135 branch March 11, 2019 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@avelino avelino Awaiting requested review from avelino

Assignees
No one assigned
Labels
version 2 RxGo v2.
Projects
None yet
Milestone
version 2
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@teivah @coveralls @avelino