Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃摑 docs: Fixed typo for func call of WithBufferedChannel. #278

Merged
merged 1 commit into from
Dec 6, 2020

Conversation

darrensapalo
Copy link
Contributor

@darrensapalo darrensapalo commented Dec 5, 2020

Very minor typo fix for now, addresses #274 .

About me
Still looking at other bug fixes/documentation that I can start with. I come from an rxjs background, and have recently learned Go; so I'm still learning the peculiarities of Golang the language. I am still looking at how I might be able to use RxGo on my projects.

@darrensapalo darrensapalo mentioned this pull request Dec 5, 2020
@coveralls
Copy link

Pull Request Test Coverage Report for Build 842

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 0.0%

Totals Coverage Status
Change from base Build 841: 0.0%
Covered Lines: 0
Relevant Lines: 0

馃挍 - Coveralls

@teivah teivah merged commit a5530d2 into ReactiveX:master Dec 6, 2020
@teivah
Copy link
Member

teivah commented Dec 6, 2020

Hi @darrensapalo.
To be fair I'm struggling a bit right now with my workload so contributors are more than welcome.
I noticed that you started to answer a couple of open questions so thank you very much for that.

If you are interested, you can also take a look at the internal of RxGo. I'm more than open to suggestions/improvements/bug fixes, etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants