-
Notifications
You must be signed in to change notification settings - Fork 7.6k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Update Gradle task dependencies to remove dependsOn 'build' task (#7255)
It is generally discouraged to add dependencies on 'build', so 'javadocCleanup' and 'jacocoTestReport' have been removed and put on better tasks. Also, 'jacocoTestReport' needs input from the test results. Updated task dependencies: - Gradle 'javadoc' task is finalized by 'javadocCleanup', and 'javadocCleanup' no longer directly invoked by 'build' - Gradle 'jacocoTestReport' task run by 'check' instead of 'build', and 'jacocoTestReport' depends on 'test' and 'testng' Changes due to dependency updates: - Add 'javadoc' generation task on Github actions that only 'build' - Remove 'javadocCleanup' task from Github action as 'publish...' tasks already dependent on 'javadoc' Miscellaneous tangential cleanup: - Remove "pr" parameter on command line in Github workflow as parameter is no longer functional - Enclose source/target compatibility in Gradle java block
- Loading branch information
1 parent
93e5216
commit 06294de
Showing
7 changed files
with
25 additions
and
16 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -57,4 +57,3 @@ def fixJavadocFile(file) { | |
file.setText(fileContents, 'UTF-8'); | ||
} | ||
|
||
build.dependsOn javadocCleanup |