Merge pull request #1301 from jbripley/subscription-block-expression

RxScala: Add convenience method for adding unsubscription callback
ReactiveX · Jun 1, 2014 · 400f69b · 400f69b
2 parents 5b5d58f + 9c74545
commit 400f69b
Show file tree

Hide file tree

Showing 2 changed files with 24 additions and 0 deletions.
diff --git a/language-adaptors/rxjava-scala/src/main/scala/rx/lang/scala/Subscriber.scala b/language-adaptors/rxjava-scala/src/main/scala/rx/lang/scala/Subscriber.scala
@@ -20,6 +20,15 @@ trait Subscriber[-T] extends Observer[T] with Subscription {
     asJavaSubscriber.add(s.asJavaSubscription)
   }
 
+  /**
+   * Register a callback to be run when Subscriber is unsubscribed
+   *
+   * @param u callback to run when unsubscribed
+   */
+  final def add(u: => Unit): Unit = {
+    asJavaSubscriber.add(Subscription(u).asJavaSubscription)
+  }
+
   override final def unsubscribe(): Unit = {
     asJavaSubscriber.unsubscribe()
   }

diff --git a/language-adaptors/rxjava-scala/src/test/scala/rx/lang/scala/SubscriberTests.scala b/language-adaptors/rxjava-scala/src/test/scala/rx/lang/scala/SubscriberTests.scala
@@ -42,4 +42,19 @@ class SubscriberTests extends JUnitSuite {
     assertTrue(innerSubscriber.isUnsubscribed)
   }
 
+  @Test def testBlockCallbackOnlyOnce() {
+    var called = false
+    val o = Observable[Int](subscriber => {
+      subscriber.add({ called = !called })
+    })
+
+    val subscription = o.subscribe()
+    subscription.unsubscribe()
+    subscription.unsubscribe()
+
+    // Even if called multiple times, callback is only called once
+    assertTrue(called)
+    assertTrue(subscription.isUnsubscribed)
+  }
+
 }