Skip to content

Commit

Permalink
3.x: Fix ExecutorScheduler initializing Schedulers prematurely
Browse files Browse the repository at this point in the history
  • Loading branch information
akarnokd committed Aug 25, 2021
1 parent 804b8ef commit fdf8010
Showing 1 changed file with 5 additions and 3 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,9 @@ public final class ExecutorScheduler extends Scheduler {
@NonNull
final Executor executor;

static final Scheduler HELPER = Schedulers.single();
static final class SingleHolder {
static final Scheduler HELPER = Schedulers.single();
}

public ExecutorScheduler(@NonNull Executor executor, boolean interruptibleWorker, boolean fair) {
this.executor = executor;
Expand Down Expand Up @@ -97,7 +99,7 @@ public Disposable scheduleDirect(@NonNull Runnable run, final long delay, final

final DelayedRunnable dr = new DelayedRunnable(decoratedRun);

Disposable delayed = HELPER.scheduleDirect(new DelayedDispose(dr), delay, unit);
Disposable delayed = SingleHolder.HELPER.scheduleDirect(new DelayedDispose(dr), delay, unit);

dr.timed.replace(delayed);

Expand Down Expand Up @@ -215,7 +217,7 @@ public Disposable schedule(@NonNull Runnable run, long delay, @NonNull TimeUnit
return EmptyDisposable.INSTANCE;
}
} else {
final Disposable d = HELPER.scheduleDirect(sr, delay, unit);
final Disposable d = SingleHolder.HELPER.scheduleDirect(sr, delay, unit);
sr.setFuture(new DisposeOnCancel(d));
}

Expand Down

0 comments on commit fdf8010

Please sign in to comment.