Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collection of tiny issues detected by IntelliJ IDEA :) #1266

Closed
orangy opened this issue May 27, 2014 · 5 comments
Closed

Collection of tiny issues detected by IntelliJ IDEA :) #1266

orangy opened this issue May 27, 2014 · 5 comments

Comments

@orangy
Copy link

orangy commented May 27, 2014

Observable:
lift - parameter "lift" not documented
pivot - parameter "groups" not documented
merge - duplicate @return
range - if ((start + count) > Integer.MAX_VALUE) -- condition is always false
dematerialize - @throws Throwable not declared by method (as far as I can see it throws OnErrorNotImplementedException)
range, elementAt, forEach - duplicate @throws IllegalArgumentException
unsafeSubscribe - parameter 'subscriber' not documented
subscribe - hook.onSubscribeError(r); -- throws r, not the result of hook
ThrowObservable - "@return a reference to the subscription" on void method

RxJavaObservableExecutionHook.onSubscribeStart - typo in parameter name "observableInsance"

CompositeException - messagePrefix not used

(more to come)

@zsxwing
Copy link
Member

zsxwing commented May 28, 2014

range - if ((start + count) > Integer.MAX_VALUE) -- condition is always false

Good catch. Should be start > Integer.MAX_VALUE - count

@benjchristensen
Copy link
Member

Thanks @orangy for referencing these.

@benjchristensen
Copy link
Member

Thanks @zsxwing for fixing that item and @DavidMGross for fixing Javadoc issues.

@benjchristensen
Copy link
Member

Please continue submitting PRs to fix these and similar issues as they are found.

benjchristensen added a commit that referenced this issue Jul 24, 2014
as per #1266
benjchristensen added a commit that referenced this issue Jul 24, 2014
@benjchristensen
Copy link
Member

I believe these are all done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants