Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Releasing 1.1.0 #3378

Closed
6 tasks done
abersnaze opened this issue Sep 25, 2015 · 11 comments
Closed
6 tasks done

Releasing 1.1.0 #3378

abersnaze opened this issue Sep 25, 2015 · 11 comments

Comments

@abersnaze
Copy link
Contributor

I would like to share what out plans are for 1.1.0. At the moment we've built up quite a lot of @Experimental APIs that we would like more confidence in using long term in production. To that end we would like to promote them to express that they are stable. I've captured some consensus among the core committers about what APIs we would like the promote. Because it wasn't entirely unanimous this is what I plan to do:

  • Last call for merges before publishing 1.0.15 for the next two weeks. Our goal is to only have changes to the annotations between the last patch and 1.1.0 so that they are functionally equivalent.
  • Submit PRs to change the annotations on various APIs but not merge them.
  • Discus the various merits of the PRs.
  • Publish 1.0.15.
  • Merge the annotation change PRs that we can agree on (minimum of 3 👍 or three weeks which ever is first).
  • Publish 1.1.0.
@akarnokd
Copy link
Member

👍 sounds great.

Submit PRs to change the annotations on various APIs but not merge them.

I'd like to add that Observable hosts quite a set of the proposed APIs and may become difficult to have non-conflicting PRs targeting this single class, if said PRs are per functionality and not per class.

@DavidMGross
Copy link
Collaborator

Please don't forget to update the "@SInCE" javadoc annotations as well if
you remove the @Experimental/@beta annotations as you promote any APIs.
You can set @SInCE to simply the string "1.1.0"

On Fri, Sep 25, 2015 at 12:45 PM, George Campbell notifications@github.com
wrote:

I would like to share what out plans are for 1.1.0. At the moment we've
built up a quite a lot of @experimental APIs that we would like more
confidence in using long term in production. To that end we would like to
promote them to express that they are stable. I've captured some consensus
among the core committers about what APIs we would like the promote. It
wasn't entirely unanimous and this is what I'm planning to do.

  • Last call for merges before publishing a 1.0.15 for the next two
    weeks. Our goal is to only have changes to the annotations between the last
    patch and 1.1.0; so that they are functionally equivalent.
  • Submit PRs to change the annotations on various APIs but not merge
    them.
  • Discus the various merits of the PRs.
  • Publish 1.0.15.
  • Merge the annotation change PRs that we can agree on (minimum of 3 [image:
    👍] or three weeks which ever is first).
  • Publish 1.1.0.


Reply to this email directly or view it on GitHub
#3378.

David M. Gross
PLP Consulting

@abersnaze
Copy link
Contributor Author

@akarnokd I have faith in git's abilities to handle mutually exclusive changes in the same file.

@abersnaze
Copy link
Contributor Author

@DavidMGross thanks for the reminder.

@akarnokd
Copy link
Member

Submit PRs to change the annotations on various APIs but not merge them.

To be clear, will you @abersnaze port these PRs or should this task be shared among us all?

@abersnaze
Copy link
Contributor Author

I've got a spreadsheet that I've collected the feed back in. I was planning on submitting most these PRs.

@akarnokd
Copy link
Member

akarnokd commented Oct 1, 2015

If you don't mind, I'll handle the cases which I proposed, especially if it involves removing a feature because the dependencies have to be cleared up as well.

@akarnokd
Copy link
Member

akarnokd commented Oct 1, 2015

Never mind, I've done all PRs, although grouped by function instead of the grouping in the spreadsheet.

@abersnaze
Copy link
Contributor Author

Last call for pull requests to be merged for 1.0.15. I'm trying to recruit @stevegury and @stealthcode to help review #3169 and #3150.

@stealthcode
Copy link

@akarnokd @abersnaze the public api promotion changes all have the javadoc annotation @since 1.0.15. I thought the promotions were going to be accepted after 1.0.15 but before 1.1.0. In that case shouldn't the annotations say 1.1.0?

@abersnaze
Copy link
Contributor Author

All the tasks were done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants