Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.2.2 release preparations #4773

Closed
akarnokd opened this issue Oct 26, 2016 · 2 comments
Closed

1.2.2 release preparations #4773

akarnokd opened this issue Oct 26, 2016 · 2 comments

Comments

@akarnokd
Copy link
Member

akarnokd commented Oct 26, 2016

Version 1.2.2 - November 3, 2016 (Maven)

Note that the interface Cancellable has been moved to rx.functions affecting CompletableEmitter and the experimental Observable.fromEmitter(Action1<AsyncEmitter<T>> emitter, AsyncEmitter.BackpressureMode backpressure) has been removed.

Another important clarification was added to the javadoc about using SingleSubscriber: due to the internal enhancements of Single, a SingleSubscriber is no longer wrapped into a Subscriber+SafeSubscriber which setup used to call unsubscribe on the SingleSubscriber yielding isUnsubscribed() == true when the source terminated. Therefore, when one extends the class SingleSubscriber, the unsubscribe() should be called manually to yield the given expecation mentioned before:

Subscritpion s = Single.just(1).subscribe(new SingleSubscriber<Integer>() {
    @Override public void onSuccess(Integer t) {
        System.out.println("Success");
        unsubscribe();
    }

    @Override public void onError(Throwable e) {
        e.printStackTrace();
        unsubscribe();
    }
});

assertTrue(s.isUnsubscribed());

Documentation enhancements

  • Pull 4693: improve timer javadoc
  • Pull 4769: Add note to SingleSubscriber doc about unsubscribe invocation in onSuccess and onError.

API enhancements

Performance enhancements

  • Pull 4676: Make identity function a singleton.
  • Pull 4764: zip - check local boolean before volatile in boolean and

Bugfixes

  • Pull 4716: fixsubscribe(Action1 [, Action1]) to report isUnsubscribed true after the callbacks were invoked
  • Pull 4740: Error when tracking exception with unknown cause
  • Pull 4791: Add null check to Observable.switchIfEmpty
@davidmoten
Copy link
Collaborator

👍

1 similar comment
@zsxwing
Copy link
Member

zsxwing commented Oct 28, 2016

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants