Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.x: Error when tracking exception with unknown cause #4740

Merged
merged 1 commit into from
Oct 22, 2016

Conversation

pyricau
Copy link

@pyricau pyricau commented Oct 21, 2016

@codecov-io
Copy link

codecov-io commented Oct 21, 2016

Current coverage is 83.95% (diff: 100%)

Merging #4740 into 1.x will increase coverage by 0.06%

@@                1.x      #4740   diff @@
==========================================
  Files           286        286          
  Lines         17753      17756     +3   
  Methods           0          0          
  Messages          0          0          
  Branches       2701       2701          
==========================================
+ Hits          14893      14907    +14   
+ Misses         1985       1975    -10   
+ Partials        875        874     -1   

Powered by Codecov. Last update 1f65cbb...f4d2f25

@akarnokd akarnokd changed the title #4737 Error when tracking exception with unknown cause 1.x: Error when tracking exception with unknown cause Oct 21, 2016
@akarnokd akarnokd added the Bug label Oct 21, 2016
@akarnokd akarnokd added this to the 1.3 milestone Oct 21, 2016
exception.initCause(this);
try {
exception.initCause(this);
} catch (IllegalStateException e) {
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should probably rename e to ignored

@akarnokd akarnokd merged commit 5e3f6c4 into ReactiveX:1.x Oct 22, 2016
@pyricau pyricau deleted the py/unknown_cause branch October 22, 2016 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants