Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Concat shares its innerSubscription among observers #583

Closed
akarnokd opened this issue Dec 8, 2013 · 0 comments
Closed

Concat shares its innerSubscription among observers #583

akarnokd opened this issue Dec 8, 2013 · 0 comments

Comments

@akarnokd
Copy link
Member

akarnokd commented Dec 8, 2013

I think L59 in Concat shares the inner subscription among any observers, so when two observers subscribe to the same concat() structure, they get a race on the inner subscription. I believe they should run independently.

In addition, on L124-L125 and L134, innerSubscription is accessed while not holding the synchronized (nextSequences) lock.

Thoughs?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@akarnokd