Func0 can transparently implement java.util.concurrent.Callable. #1003
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change doesn't change the API at all for users of Func0, but it makes all Func0 objects immediately reusable with any JDK API that accepts Callables. For example, a Func0 can now be submitted directly to an ExecutorService for asynchronous execution. It also allows the elimination of a small amount of redundant code within RxJava itself.
|
Looks like a fine change ... anyone else have comments on this? /cc @akarnokd |
|
Fine with me. |
|
Thanks |
benjchristensen
added a commit
that referenced
this pull request
Mar 31, 2014
Func0 can transparently implement java.util.concurrent.Callable.
|
RxJava-pull-requests #933 FAILURE |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change doesn't change the API at all for users of
Func0, but it makes allFunc0objects immediately reusable with any JDK API that acceptsCallables. For example, aFunc0can now be submitted directly to anExecutorServicefor asynchronous execution. It also allows the elimination of a small amount of redundant code within RxJava itself.