add toMap from Java Observable #1005
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please also add some examples to |
| * @return an Observable that emits a single item: a Map containing the mapped items from the source | ||
| * Observable | ||
| */ | ||
|
|
There was a problem hiding this comment.
please keep style consistant: no newlines between doc and method ;-)
Added examples for all three overloads and removed newlines between methods and docs
|
When I run the |
Implementation corrected to not raise exceptions
|
RxJava-pull-requests #934 FAILURE |
|
Seems that there was some git error... |
|
Tests pass for me, merging. |
benjchristensen
added a commit
that referenced
this pull request
Apr 15, 2014
add toMap from Java Observable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added three overloads of toMap to Scala Observable