Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UnsafeSubscribe #1010

Merged
merged 3 commits into from
Apr 3, 2014
Merged

Conversation

benjchristensen
Copy link
Member

Migrate from reflection to unsafeSubscribe as per discussion at #676

All operators are migrated to using unsafeSubscribe instead of relying on their package to avoid SafeSubscriber wrapping.

Migrate from reflection to unsafeSubscribe as per discussion at ReactiveX#676
@benjchristensen
Copy link
Member Author

With these changes I'm seeing non-deterministic failure of OperatorGroupByTest.testStaggeredCompletion. It's not yet clear why.

@cloudbees-pull-request-builder

RxJava-pull-requests #937 FAILURE
Looks like there's a problem with this pull request

@benjchristensen
Copy link
Member Author

Problem appears to be related to the delay operator: #1011

@cloudbees-pull-request-builder

RxJava-pull-requests #938 FAILURE
Looks like there's a problem with this pull request

The blocking operators need to use 'subscribe', not 'unsafeSubscribe' since they need the SafeSubscriber behavior in the final subscribe step they perform.
Renamed operators to BlockingOperator* for clarity and to match the Operation->Operator naming change.
@benjchristensen
Copy link
Member Author

The unit tests passed that were failing previously ... build is timing out on Quasar tests for some reason (though they work on our other build servers and locally).

benjchristensen added a commit that referenced this pull request Apr 3, 2014
@benjchristensen benjchristensen merged commit c09efd8 into ReactiveX:master Apr 3, 2014
@benjchristensen benjchristensen deleted the unsafe-subscribe branch April 3, 2014 04:41
@cloudbees-pull-request-builder

RxJava-pull-requests #940 ABORTED

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants