add synchronous test of resubscribe after error #1068
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
RxJava-pull-requests #983 SUCCESS |
|
Thank you! |
benjchristensen
added a commit
that referenced
this pull request
Apr 23, 2014
add synchronous test of resubscribe after error
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've added a simple synchronous test of resubscription after error. Retry has had a chequered history of late and I think might benefit from extra tests. The scenario is perhaps covered by the recent additions with #1027 but the test additions for that were async and more complex. This simple scenario broke for versions to 0.16.1 to 0.17.4, hung with 0.17.5 and passes in 0.17.6.