Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OperatorBuffer #1073

Merged
merged 1 commit into from
Apr 24, 2014
Merged

OperatorBuffer #1073

merged 1 commit into from
Apr 24, 2014

Conversation

akarnokd
Copy link
Member

Operator Buffer, split into 4 variants.

Issue #1060.

There are some important behavioral changes compared to the original versions:

  • When an onError event appears from anywhere, the currently accumulated chunk(s) are NOT emitted before the error is propagated. This conforms with Rx Design Guideline 6.6.
  • The Observable returned by the Func0 inside the buffer(Func0<Observable<B>>) now is used as long as possible and whenever it fires an event, a new buffer chunk is started. The Func0 is called only once per subscriber. The original called it and subscribed to it all the time, causing all-increasing resubscriptions.

@cloudbees-pull-request-builder

RxJava-pull-requests #986 SUCCESS
This pull request looks good

@akarnokd akarnokd mentioned this pull request Apr 23, 2014
57 tasks
benjchristensen added a commit that referenced this pull request Apr 24, 2014
@benjchristensen benjchristensen merged commit 1de53a2 into ReactiveX:master Apr 24, 2014
@akarnokd akarnokd deleted the OperatorBuffer branch April 24, 2014 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants