Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OperatorToMultimap #1097

Merged
merged 1 commit into from
Apr 30, 2014
Merged

OperatorToMultimap #1097

merged 1 commit into from
Apr 30, 2014

Conversation

zsxwing
Copy link
Member

@zsxwing zsxwing commented Apr 25, 2014

Operator ToMultimap

Issue #1060

@cloudbees-pull-request-builder

RxJava-pull-requests #1007 SUCCESS
This pull request looks good

*
* @see <a href='https://github.com/Netflix/RxJava/issues/97'>Issue #97</a>
*/
public class OperatorToMultimap<T, K, V> implements Operator<Map<K, Collection<V>>, T> {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a remark, we should use final on classes as much as possible in the future. I might have missed a few too, but once the operators have been reimplemented, we can make a cleanup pass.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup

@akarnokd akarnokd mentioned this pull request Apr 25, 2014
57 tasks
@cloudbees-pull-request-builder

RxJava-pull-requests #1009 SUCCESS
This pull request looks good

@benjchristensen benjchristensen merged commit 96b64b1 into ReactiveX:master Apr 30, 2014
@zsxwing zsxwing deleted the to-multimap branch April 30, 2014 03:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants