OperatorTimerAndSample #1098
Merged
OperatorTimerAndSample #1098
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Operator Timer and Sample
Because there was a dependency in Sample towards the now removed Interval, I had to reimplement Sample in this PR as well.
Note that the new
OperatorSampleWithTimeschedules its first sample call before any upstream code is executed. Given the TestScheduler, a sample with 1sec and a timer with 1sec as well won't sample any value. The reason is that in the internal queue of TestScheduler, the sampler's action to take the sample is followed by the action to emit the timer's value.