Add lift to rxscala #1124
Add lift to rxscala #1124
Conversation
|
RxJava-pull-requests #1036 FAILURE |
| // Add "No. " in front of each item | ||
| val o = List(1, 2, 3).toObservable.lift { | ||
| subscriber: Subscriber[String] => | ||
| Subscriber( |
There was a problem hiding this comment.
even if it's not required, I'd write Subscriber[Int] here, so that people immediately see that the function is of type Subscriber[String] => Subscriber[Int]
|
RxJava-pull-requests #1037 FAILURE |
|
Thank you for reviewing the codes, @samuelgruetter. I added the Operator conversion, and the Do you have any better idea about |
|
RxJava-pull-requests #1044 SUCCESS |
|
Is this ready? |
| @@ -54,4 +54,12 @@ object JavaConversions { | |||
| val asJavaObservable = observable | |||
| } | |||
| } | |||
|
|
|||
| implicit def toJavaOperator[T, R](operator: Subscriber[R] => Subscriber[_ >: T]): rx.Observable.Operator[R, T] = { | |||
There was a problem hiding this comment.
Why do you use _ >: T on a contravariant Scala type?
There was a problem hiding this comment.
Thank you. Already removed it.
|
RxJava-pull-requests #1053 SUCCESS |
|
LGTM. Thank you @zsxwing |
This PR added
liftto RxScala and also added aSubscriber.applymethod to support to chainSubscribers./cc @samuelgruetter