Rxscala improvement #1159
Merged
Rxscala improvement #1159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
RxJava-pull-requests #1071 FAILURE |
|
Looks the failure is due to the cloudbees network issue. |
|
RxJava-pull-requests #1075 FAILURE |
|
RxJava-pull-requests #1076 SUCCESS |
|
Scala users all okay with this? |
|
I am. |
| def ::[U >: T](elem: U): Observable[U] = { | ||
| val thisJava = this.asJavaObservable.asInstanceOf[rx.Observable[U]] | ||
| toScalaObservable(thisJava.startWith(elem)) | ||
| } |
There was a problem hiding this comment.
I would not add this method (see #1151 (comment) why)
zsxwing
added a commit
to zsxwing/RxJava
that referenced
this pull request
May 7, 2014
benjchristensen
added a commit
that referenced
this pull request
May 8, 2014
Update according to review in issue #1159
jbripley
pushed a commit
to jbripley/RxJava
that referenced
this pull request
May 17, 2014
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
dropUntil,contains,repeat,doOnTerminate,startWith,publishvariants to RxScala. #1151, #1153./cc @headinthebox @samuelgruetter