Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed use of deprecated API from tests & operators, fixed year in head... #1161

Merged

Conversation

akarnokd
Copy link
Member

@akarnokd akarnokd commented May 6, 2014

...ers, added and removed suppressions, fixed line endings, replaced tabs with spaces

I haven't deleted OnSubscribeFunc because I was not sure when the general cleanup of deprecated stuff will happen; I just made sure Java tests don't use it anymore.

…eaders, added and removed suppressions, fixed line endings, replaced tabs with spaces
@cloudbees-pull-request-builder

RxJava-pull-requests #1073 FAILURE
Looks like there's a problem with this pull request

@benjchristensen
Copy link
Member

This is some seriously heroic cleanup! Thank you very much.

I'm so glad to see SafeObservableSubscription gone!

benjchristensen added a commit that referenced this pull request May 6, 2014
Removed use of deprecated API from tests & operators, fixed year in head...
@benjchristensen benjchristensen merged commit 3764051 into ReactiveX:master May 6, 2014
@headinthebox
Copy link
Contributor

Ditto.

@akarnokd akarnokd deleted the RemoveOnSubscribeFuncRefs branch May 6, 2014 20:13
@benjchristensen
Copy link
Member

Reviewing this again while doing release notes ... thank you again @akarnokd for this. You took care of messy, tedious things here that had been piling up for a while and was constantly on the TODO list.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants