Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revision of JMH Tests #1376

Merged
merged 1 commit into from
Jun 23, 2014
Merged

Conversation

benjchristensen
Copy link
Member

This updates all perf testing to use only JMH. I tried to get all of them to follow a common pattern, and to comply with examples at https://github.com/nitsanw/jmh-samples/blob/master/src/main/java/org/openjdk/jmh/samples/ by @nitsanw. (@nitsanw if you're willing to take a look at this and confirm or correct them, I'd appreciate that).

I am doing this in 0.19 so that work on 0.20 has a common set of perf tests to use for comparison.

- removal of all non-JMH perf tests
@cloudbees-pull-request-builder

RxJava-pull-requests #1315 SUCCESS
This pull request looks good

benjchristensen added a commit that referenced this pull request Jun 23, 2014
@benjchristensen benjchristensen merged commit 4d74dd5 into ReactiveX:master Jun 23, 2014
@benjchristensen benjchristensen deleted the jmh branch June 23, 2014 21:48
@nitsanw
Copy link
Contributor

nitsanw commented Jun 24, 2014

Sorry, not sure when I'll be able to review these changes.
In the next few days/weeks perhaps…

@benjchristensen
Copy link
Member Author

@nitsanw No problem, I know you're very busy. If you ever have the chance and interest, it would be good to know we're following your examples right. In the meantime though I'm pushing forward based on my current understandings of how to use JMH. I appreciate your responses and involvement in our project!

@nitsanw
Copy link
Contributor

nitsanw commented Jun 25, 2014

My examples are very dated by now, you should look at the latest samples on the JMH project.

On 25 Jun 2014, at 18:34, Ben Christensen notifications@github.com wrote:

@nitsanw No problem, I know you're very busy. If you ever have the chance and interest, it would be good to know we're following your examples right. In the meantime though I'm pushing forward based on my current understandings of how to use JMH. I appreciate your responses and involvement in our project!


Reply to this email directly or view it on GitHub.

@benjchristensen
Copy link
Member Author

I ended up finding those after looking at yours, and went through them as well. I assume you're referring to these? http://hg.openjdk.java.net/code-tools/jmh/file/tip/jmh-samples/src/main/java/org/openjdk/jmh/samples/

@nitsanw
Copy link
Contributor

nitsanw commented Jun 26, 2014

Yes. :)

On 25 Jun 2014, at 21:22, Ben Christensen notifications@github.com wrote:

I ended up finding those after looking at yours, and went through them as well. I assume you're referring to these? http://hg.openjdk.java.net/code-tools/jmh/file/tip/jmh-samples/src/main/java/org/openjdk/jmh/samples/


Reply to this email directly or view it on GitHub.

@shipilev
Copy link

shipilev commented Jul 2, 2014

Hi there :) Not sure if that's intentional or not, but poking around a few benchmarks there, it seems you can make them even cleaner: instead of using the explicit Input nested class, you might as well use the enclosing class holding the @Benchmark methods as @State class. You seem to be having @State(Thread) already on the enclosing classes, only to delegate everything to nested class afterwards...

That is, this sample works:
http://hg.openjdk.java.net/code-tools/jmh/file/0.9/jmh-samples/src/main/java/org/openjdk/jmh/samples/JMHSample_04_DefaultState.java

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants