Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Variety of Fixes #1380

Merged
merged 6 commits into from
Jun 24, 2014
Merged

Variety of Fixes #1380

merged 6 commits into from
Jun 24, 2014

Commits on Jun 24, 2014

  1. TakeUntil & NotificationLite 

    A rewrite of TakeUntil that doesn't leak NotificationLite.COMPLETE outside of itself. It causes problems to leak the sentinels as other operators also using NotificationLite get confused.
    @benjchristensen
    benjchristensen committed Jun 24, 2014
    Configuration menu
    Copy the full SHA
    a7f80c3 View commit details
    Browse the repository at this point in the history

  2. Remove unnecessary code

    @benjchristensen
    benjchristensen committed Jun 24, 2014
    Configuration menu
    Copy the full SHA
    af4fc88 View commit details
    Browse the repository at this point in the history

  3. OnSubscribe: DelaySubscribe -> UnsafeSubscribe 

    This could cause an unwanted unsubscribe to be propagate because of the `SafeSubscriber`
    @benjchristensen
    benjchristensen committed Jun 24, 2014
    Configuration menu
    Copy the full SHA
    59b59b2 View commit details
    Browse the repository at this point in the history

  4. Formatting

    @benjchristensen
    benjchristensen committed Jun 24, 2014
    Configuration menu
    Copy the full SHA
    d06c7d6 View commit details
    Browse the repository at this point in the history

  5. TestSubscriber.assertNoErrors

    @benjchristensen
    benjchristensen committed Jun 24, 2014
    Configuration menu
    Copy the full SHA
    acc5c1e View commit details
    Browse the repository at this point in the history

  6. TrampolineScheduler Cleanup 

    Remove the null check and lazy creation, build the queue in the ThreadLocal. Fix bugs about "work in progress".
    @benjchristensen
    benjchristensen committed Jun 24, 2014
    Configuration menu
    Copy the full SHA
    875cfd7 View commit details
    Browse the repository at this point in the history