Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CompositeException stops mutating nested Exceptions #1388

Merged
merged 3 commits into from
Jun 25, 2014
Merged

CompositeException stops mutating nested Exceptions #1388

merged 3 commits into from
Jun 25, 2014

Commits on Jun 25, 2014

  1. CompositeException does not mutate nested exceptions by attaching sta… 

    …cks, but instead

aggregates them at print-time.

Since nothing is being mutated, there's no chance of accidentally creating a cycle in the Exception chain.
    @mattrjacobs
    mattrjacobs committed Jun 25, 2014
    Configuration menu
    Copy the full SHA
    f4ae92a View commit details
    Browse the repository at this point in the history

  2. Removed unused import

    @mattrjacobs
    mattrjacobs committed Jun 25, 2014
    Configuration menu
    Copy the full SHA
    3b95e2f View commit details
    Browse the repository at this point in the history

  3. Fixed up SafeObserverTest w.r.t. CompositeException changes

    @mattrjacobs
    mattrjacobs committed Jun 25, 2014
    Configuration menu
    Copy the full SHA
    8e27cdc View commit details
    Browse the repository at this point in the history