New operation Finally (issue #43) #196
Conversation
|
This implements issue #43 (but apparently github doesn't autolinkify issue numbers in pull-request titles like it does in comments.) |
|
RxJava-pull-requests #33 SUCCESS |
|
@abliss seems like you forgot to add |
|
RxJava-pull-requests #34 FAILURE |
|
@prabirshrestha thanks for the comments; I added a static method to Observable. As for the try/catch, it was not at all clear to me from the MSDN documentation whether Finally would allow the error to propagate or not. I figured it ought to propagate since this matches the semantics of java's "finally" construct. Or do you mean that Finally should be using try/catch to intercept exceptions in the RxJava framework? This doesn't seem right to me. I would expect we'd rather trust the source Observable to correctly implement all the necessary try/catch blocks and use onError to propagate exceptions, right? |
|
RxJava-pull-requests #35 SUCCESS |
|
@abliss seems like you forgot to add the non-static method to Even I'm not sure about the |
|
Thanks again @prabirshrestha ; I have added it. |
|
RxJava-pull-requests #36 SUCCESS |
| } | ||
|
|
||
| @Test | ||
| public void testFinally() { |
There was a problem hiding this comment.
It's a good practice to keep unit tests atomic. Consider splitting this test to two separate ones. First one that checks successfully completed observable and second one would check onError use case.
|
@abliss Here is the .net code I checked with. new[] { 1, 2 }
.ToObservable()
.Finally(() =>
{
Console.WriteLine("finally block");
throw new Exception("finally");
})
.Subscribe(Console.WriteLine, ex => Console.WriteLine(ex.Message), () => Console.WriteLine("completed"));Output: This mean we don't need |
Splits a compound unit test into to parts. Uses mockito instead of a bespoke test object. Removes unused import statements. Changes the order of the Finally action w.r.t. onComplete/onError.
|
Thanks @prabirshrestha and @mairbek for your comments; I have fixed the issues. |
|
RxJava-pull-requests #37 SUCCESS |
|
Welcome to the project @abliss and thank you @prabirshrestha and @mairbek for the reviews on this. |
|
Thanks @benjchristensen ! If you have any suggestions for how to make this pull request more attractive, or which issues to work on next, I'm all ears. Otherwise I will probably send a pull request for issue #14 next. |
|
I've had other things taking my time this week so haven't had a chance to review and merge this yet ... I will get to it though. Issue #14 will be good as a next item. |
| * @return an Observable that emits the same objects, then calls the action. | ||
| * @see <a href="http://msdn.microsoft.com/en-us/library/hh212133(v=vs.103).aspx">MSDN: Observable.Finally Method</a> | ||
| */ | ||
| public static <T> Observable<T> finally0(Observable source, Action0 action) { |
There was a problem hiding this comment.
I know we can't have finally as the method name as it is reserved, but finally0 seems awkward. Other than Action0 (because it has different arities) what is the reasoning behind using 0 at the end? I don't think finally will ever have different arities, and if it did it would just have overloads with more arguments.
We likely want to keep the prefix finally since that's what people will be looking for coming from other Rx implementations so perhaps something like finallyDo?
- Changes finally0 to finallyDo. - Removes unnecessary subscription-wrapping. - Handle exceptions in onCompleted/onError
|
RxJava-pull-requests #58 SUCCESS |
|
Thanks for the comments; I have fixed them all. |
Hi,
I was looking around for some fun stuff to do for the Netflix Cloud Prize, and I figured I might start by contributing some enhancements to RxJava.
I did my best to match your existing style and practices, but I've doubtless made some mistakes. If you have time to take a quick look and give me some feedback, I'll accept it gratefully.
Cheers,
--abliss