OperatorMerge handle request overflow #2543
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We had a conflicting merge. Could you rebase this onto the current master? |
davidmoten
force-pushed
the
merge-request-overflow
branch
from
bf979c1
to
5348ebf
Compare
|
rebased (I think). |
|
Thanks. |
akarnokd
added a commit
that referenced
this pull request
Jan 28, 2015
OperatorMerge handle request overflow
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Calling
hangs
OperatorMergebecause the internal requested count overflows and becomes negative.This PR adds fix and unit test.
I imagine this will be in other operators as well. I'll have a hunt around.