Error handling and validation #287
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- I would like to remove the no-arg constructor but not ready to pull the trigger
…ctor - also questioning why to allow extending this and would like to make it a private constructor
As brought up in ReactiveX#278 there were inconsistencies in how arguments were being validated on subscribe methods. All arguments to subscribe are now validated correctly at the beginning of method invocation and IllegalArgumentException thrown if null arguments are injected. According to Rx Guideline 6.5 a null argument is considered "a catastrophic error occurs that should bring down the whole program anyway" and thus we immediately throw. A null argument should be caught immediately in development and has nothing to do with subscribe invocation which is what guideline 6.5 is talking about (since a null Observer can't have onError called on it anyways).
ReactiveX#198 As per Rx Design Guidelines 5.2: "when calling the Subscribe method that only has an onNext argument, the OnError behavior will be to rethrow the exception on the thread that the message comes out from the observable sequence. The OnCompleted behavior in this case is to do nothing." A new OnErrorNotImplementedException was created so it is explicit as to where the exception is coming from and why.
|
RxJava-pull-requests #158 SUCCESS |
benjchristensen
added a commit
that referenced
this pull request
Jun 4, 2013
…ation Error handling and validation
rickbw
pushed a commit
to rickbw/RxJava
that referenced
this pull request
Jan 9, 2014
…and-validation Error handling and validation
jihoonson
pushed a commit
to jihoonson/RxJava
that referenced
this pull request
Mar 6, 2020
…ements Spring boot enhancements
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactoring related to arg validation and error handling.
#198 Throw if no onError handler specified
#278 Subscribe argument validation