CompositeException extra NPE protection #3048
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| if (ex instanceof CompositeException) { | ||
| deDupedExceptions.addAll(((CompositeException) ex).getExceptions()); | ||
| } else | ||
| if (ex != null) { |
There was a problem hiding this comment.
Could you move if (ex != null) { to the same line of else?
There was a problem hiding this comment.
No. This is my style of coding and there is no style guide for RxJava anyway.
There was a problem hiding this comment.
I thought it was unintentional. Never mind. See this style for the first time :)
benjchristensen
added a commit
that referenced
this pull request
Jul 14, 2015
CompositeException extra NPE protection
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CompositeExceptionwon't crash if it received null by some means. Anullcollection ornullcollection item is replaced by aNullPointerExceptioninstance.See also: #3046.