2.x: subscribeOn allow cancelling before the actual subscription happens (just like 1.x) #4222
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is 68.55%@@ 2.x #4222 diff @@
==========================================
Files 411 411
Lines 29486 29490 +4
Methods 0 0
Messages 0 0
Branches 4777 4779 +2
==========================================
+ Hits 20212 20216 +4
+ Misses 7252 7251 -1
- Partials 2022 2023 +1
|
| TestScheduler test = Schedulers.test(); | ||
|
|
||
| TestSubscriber<Integer> ts = Flowable.just(1).hide() | ||
| .subscribeOn(test).test(Long.MAX_VALUE, 0, true); |
There was a problem hiding this comment.
Why not dispose()? In general, why same tests are different?
There was a problem hiding this comment.
Observable doesn't have backpressure, and a test method yet.
There was a problem hiding this comment.
Ok got it, so you would use test() for both while I'd use dispose(), ok
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the
subscribeOnoperator to allow cancellation before the actual subscription to the source takes place - just like how 1.x works.