Observable/Flowable/Completable/Single.delay should always call onError on the provided Scheduler #4522
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is 78.72% (diff: 100%)@@ 2.x #4522 diff @@
==========================================
Files 515 515
Lines 34647 34643 -4
Methods 0 0
Messages 0 0
Branches 5431 5431
==========================================
+ Hits 27255 27273 +18
+ Misses 5417 5402 -15
+ Partials 1975 1968 -7
|
|
👍 |
|
Great job applying the changes to all of the base types! |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4521