Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

2.x: cleanup & coverage 10/24-2 #4763

Merged
merged 1 commit into from
Oct 25, 2016
Merged

2.x: cleanup & coverage 10/24-2 #4763

merged 1 commit into from
Oct 25, 2016

Conversation

akarnokd
Copy link
Member

  • better coverage of Flowable operators
  • cleanup of operator internals
  • better coverage of standard Schedulers.
  • rewrite of takeUntil to avoid onSubscribe() races.

@akarnokd akarnokd added this to the 2.0 milestone Oct 24, 2016
@codecov-io
Copy link

codecov-io commented Oct 24, 2016 •
edited
Loading

Current coverage is 95.27% (diff: 90.47%)

Merging #4763 into 2.x will increase coverage by 0.38%

@@                2.x      #4763   diff @@
==========================================
  Files           570        570          
  Lines         36840      36784    -56   
  Methods           0          0          
  Messages          0          0          
  Branches       5588       5570    -18   
==========================================
+ Hits          34956      35045    +89   
+ Misses          870        767   -103   
+ Partials       1014        972    -42

Powered by Codecov. Last update 3634c92...cb2ce8e

JakeWharton
JakeWharton approved these changes Oct 24, 2016
View reviewed changes
src/main/java/io/reactivex/internal/schedulers/IoScheduler.java
RxJavaPlugins.onError(ex);
}
task = evictor.scheduleWithFixedDelay(this, this.keepAliveTime, this.keepAliveTime, TimeUnit.NANOSECONDS
);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: weird wrap

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will fix it in the next PR.

@akarnokd akarnokd merged commit 318bf43 into ReactiveX:2.x Oct 25, 2016
@akarnokd akarnokd mentioned this pull request Oct 27, 2016
Closed
@akarnokd akarnokd deleted the Cleanup_10_24_2 branch March 24, 2017 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JakeWharton JakeWharton JakeWharton approved these changes

Assignees
No one assigned
Labels
Bug Cleanup Coverage
Projects
None yet
Milestone
2.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@akarnokd @codecov-io @JakeWharton