2.x: fix timer() ISE due to bad resource mgmt #4927
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is 95.55% (diff: 100%)@@ 2.x #4927 diff @@
==========================================
Files 586 586
Lines 37446 37452 +6
Methods 0 0
Messages 0 0
Branches 5625 5627 +2
==========================================
- Hits 35829 35786 -43
- Misses 674 712 +38
- Partials 943 954 +11
|
JakeWharton
approved these changes
Dec 20, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Both
Observable.timer()andFlowable.timer()could reportIllegalStateExceptionbecause if the delayed task completed before the task'sDisposablewas set, thesetOncefound a non-null, non-terminal reference already set.Related: #4926.